Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu - sam3x8e: added switch for newlib-nano specs #1356

Merged
merged 1 commit into from Jul 2, 2014

Conversation

haukepetersen
Copy link
Contributor

enable the newlib nano specs if they are available.

@@ -30,7 +29,7 @@ export PORT
# define build specific options
export CPU_USAGE = -mcpu=cortex-m3
export CFLAGS += -ggdb -g3 -std=gnu99 -Os -Wall -Wstrict-prototypes $(CPU_USAGE) -mlittle-endian -mthumb -mthumb-interwork -nostartfiles
export CFLAGS += -DREENTRANT_SYSCALLS_PROVIDED
export CFLAGS += -flto -ffunction-sections -fdata-sections -fno-builtin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removed line is not needed - it was a leftover from some early testing... The added line contains some options, that are recommended when using newlib.nano, and I have found that they do not hurt for the default newlib...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you were wrong - with -flto building falls on my non-nano newlib version.

@OlegHahm
Copy link
Member

OlegHahm commented Jul 2, 2014

ACK and go.

OlegHahm added a commit that referenced this pull request Jul 2, 2014
cpu - sam3x8e: added switch for newlib-nano specs
@OlegHahm OlegHahm merged commit d52df83 into RIOT-OS:master Jul 2, 2014
@haukepetersen haukepetersen deleted the fix_sam3x_newlibnano branch July 24, 2014 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants