Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/lpc2387: timer: use lpc2387_pclk_scale() #13903

Merged
merged 1 commit into from May 7, 2020
Merged

cpu/lpc2387: timer: use lpc2387_pclk_scale() #13903

merged 1 commit into from May 7, 2020

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Apr 19, 2020 •
edited

Contribution description

It appears as if this function was just made for this kind of purpose, so make use of it to get the optimal DIV / prescaler combination.

Testing procedure

Issues/PRs references

split out from #13902

@benpicco benpicco added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: cpu Area: CPU/MCU ports labels Apr 19, 2020
@benpicco benpicco requested a review from maribu April 19, 2020 13:35
@maribu
Copy link
Member

maribu commented Apr 26, 2020

Mind to piggy-back a commit adding some details to the sparse doc of lpc2387_pclk_scale()?

maribu
maribu approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Tested with tests/periph_timer and also used tests/xtimer_msg to confirm there are no regressions.

@maribu maribu added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 7, 2020
@maribu maribu merged commit 0fe24e1 into RIOT-OS:master May 7, 2020
@benpicco benpicco deleted the cpu/lpc2387/timer_pclk_scale branch May 7, 2020 20:43
@miri64 miri64 added this to the Release 2020.07 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benpicco @maribu @miri64