Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor include fixes #142

Merged
merged 4 commits into from Aug 15, 2013
Merged

Minor include fixes #142

merged 4 commits into from Aug 15, 2013

Conversation

OlegHahm
Copy link
Member

Some tiny include and prototype additions

@@ -1,323 +1,324 @@
/* Copyright (C) 2004 Christopher Clark <firstname.lastname@cl.cam.ac.uk> */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline changes?

@miri64
Copy link
Member

miri64 commented Aug 15, 2013

Appart from some changes, that are not mentioned in the title of this PR, ACK.

OlegHahm added a commit that referenced this pull request Aug 15, 2013
Minor include, function prototype, and coding convention fixes
@OlegHahm OlegHahm merged commit 1d9ce4d into RIOT-OS:master Aug 15, 2013
@OlegHahm OlegHahm deleted the minor_include_fixes branch August 15, 2013 08:55
@@ -1,4 +1,4 @@
MODULE:=$(shell basename $(CURDIR))
INCLUDES = -I$(RIOTBASE) -I$(RIOTBASE)/sys/include -I$(RIOTBASE)/core/include -I$(RIOTBASE)/sys/net/sixlowpan/include
INCLUDES += -I$(RIOTBASE) -I$(RIOTBASE)/sys/include -I$(RIOTBASE)/core/include -I$(RIOTBASE)/sys/net/sixlowpan/include
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+= here, but not in the other cases? Is there any reason for this?

@OlegHahm
Copy link
Member Author

Not really. It was just the fastest solution here as net_help is always used with sixlowpan. Anyway, the whole build system is inconsistent.

However, adding probably to many (internal) paths to the INCLUDES do not break anything.

eduazocar pushed a commit to eduazocar/RIOT that referenced this pull request Jul 1, 2022
wifi-subsys: add main of wifi subsys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants