drivers/at: improve URC handling #14914
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the ublox cellular modem AT reference manual, a delay of -at least- 20ms is required before starting a new command operation so that the modem has time to send the stored URC messages to the host. It is also important to note that this delay is inserted just BEFORE draining the AT device so as to receive and process possible URCs. Another point to keep in mind is that this delay is put in functions which constitute a whole AT command, i.e. sending the command and waiting for the answer. The remaning functions like at_send_bytes or at_recv_bytes do not have this delay. The users, who will use those functions in their own implementation, are advised to respect this timing.
With this commit, we attempt to fix some URC missing failures that we have experienced so far. According to the basic test results with the ublox SARA modem, these changes seem to be promising. However, we need more detailed testing to come up with a final conclusion.
vincent-d
added
Type: enhancement
|
@leandrolanzieri do you think you can find time to have a look at this one ? |
leandrolanzieri
moved this from Backlog / Proposals
to Ready for Review
in RIOT Sprint Day
|
Can you provide some test output @vincent-d ? |
fjmolinas
reviewed
Mar 30, 2021
There was a problem hiding this comment.
A few comments, if you provide some test results we can move forward with this one @vincent-d.
| @@ -210,6 +269,7 @@ ssize_t at_send_cmd_get_resp(at_dev_t *dev, const char *command, | |||
| { | |||
| ssize_t res; | |||
|
|
|||
| xtimer_usleep(AT_CMD_DELAY); | |||
There was a problem hiding this comment.
xtimer is added but not as a dependency to the driver (you might consider using ztimer as well)
| return rb->buf[rb->reads & (rb->size - 1)]; | ||
| } | ||
|
|
||
| int tsrb_peek_one(tsrb_t *rb, uint8_t *dst) |
There was a problem hiding this comment.
Can you add a test for this in test-tsrb.c?
benpicco
added
the
State: waiting for author
|
ping @vincent-d |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
stale
bot
added
the
State: stale
|
I will try to finalize this PR. |
stale
bot
removed
the
State: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Those changes improved our situation regarding URC with our modem.
main changes:
at_drain()at_expect()Rationale: a URC can be emitted while a command is being sent before the echo is received.
The credit (and hopefully the support for this PR ;p ) goes to @aaltuntas