Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ieee802154_hal: add cap for register retention during off #14997

Merged
merged 2 commits into from Sep 10, 2020

Conversation

jia200x
Copy link
Member

@jia200x jia200x commented Sep 10, 2020

Contribution description

This PR adds a radio cap for indicating that the radio can keep the content of all register when off. This is required to indicate the upper layer that in some cases it might be necessary to set the PIB again.

This still leaves room for several use cases:

  • Users that don't require register retention (because the CPU hibernates) and simply reboot on wake-up can ignore setting the PIB after off.
  • Users that require register retention (radio sleeps but CPU is still awake) can set the PIB if the cap is not there.

It also specifies that during boot, the PIB is undefined (so it should be set once confirm_on returns 0).

I also piggybacked a misplaced note that was probably a left-over of the cleanup in #14371

Testing procedure

The output of Travis should be enough

Issues/PRs references

Discussed in #14802

@jia200x jia200x changed the title ieee802154_hal: add cap for register retention during off ieee802154_hal: add cap for register retention during off Sep 10, 2020
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition, only API defined so far.

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 10, 2020
@jia200x
Copy link
Member Author

jia200x commented Sep 10, 2020

squashed

@jia200x jia200x added Area: network Area: Networking Area: drivers Area: Device drivers labels Sep 10, 2020
@benpicco benpicco merged commit 8a2080a into RIOT-OS:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants