Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/driver_ds3231: blacklist on CI #15554

Merged
merged 1 commit into from Dec 3, 2020
Merged

tests/driver_ds3231: blacklist on CI #15554

merged 1 commit into from Dec 3, 2020

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Dec 3, 2020

Contribution description

The test needs real hardware to run, so including it in the automated CI tests will always fail.

Testing procedure

Issues/PRs references

@benpicco
tests/driver_ds3231: blacklist on CI
c82e331 
The test needs real hardware to run, so including it in the automated
CI tests will always fail.
@benpicco benpicco added Area: tests Area: tests and testing framework Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Dec 3, 2020
@benpicco benpicco requested a review from maribu December 3, 2020 20:07
maribu
maribu approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Dec 3, 2020
@benpicco benpicco merged commit 1eab23a into RIOT-OS:master Dec 3, 2020
@benpicco benpicco deleted the tests/driver_ds3231 branch December 3, 2020 23:44
@maribu maribu mentioned this pull request Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benpicco @maribu