Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/qn908x: Add the RTC module. #15567

Merged
merged 1 commit into from Dec 6, 2020
Merged

cpu/qn908x: Add the RTC module. #15567

merged 1 commit into from Dec 6, 2020

Conversation

iosabi
Copy link
Contributor

@iosabi iosabi commented Dec 5, 2020

Contribution description

This patch implements the real time clock module for the QN908X cpus.

This module is very straightforward with only the one notable drawback
that it doesn't have a match register like the CTIMER block to implement
the alarm function. Instead, this driver can only use the interrupt
generated ever 1 second to implement the alarm match comparison in
software.

Testing procedure

make BOARD=qn9080dk -C tests/periph_rtc all flash test

Issues/PRs references

This is part of #13852.

benpicco
benpicco reviewed Dec 6, 2020
View reviewed changes
cpu/qn908x/periph/rtc.c Outdated Show resolved Hide resolved
benpicco
benpicco reviewed Dec 6, 2020
View reviewed changes
cpu/qn908x/periph/rtc.c Outdated Show resolved Hide resolved
@benpicco benpicco added Area: cpu Area: CPU/MCU ports Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Dec 6, 2020
@iosabi
cpu/qn908x: Add the RTC module.
3890091 
This patch implements the real time clock module for the QN908X cpus.

This module is very straightforward with only the one notable drawback
that it doesn't have a match register like the CTIMER block to implement
the alarm function. Instead, this driver can only use the interrupt
generated ever 1 second to implement the alarm match comparison in
software.
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 6, 2020
@benpicco
Copy link
Contributor

benpicco commented Dec 6, 2020

Does tests/periph_rtc still work?

@iosabi
Copy link
Contributor Author

iosabi commented Dec 6, 2020

Does tests/periph_rtc still work?

$ ./dist/tools/compile_and_test_for_board/compile_and_test_for_board.py . qn9080dk --applications tests/periph_rtc
INFO:qn9080dk:Saving toolchain
INFO:qn9080dk.tests/periph_rtc:Board supported: True
INFO:qn9080dk.tests/periph_rtc:Board has enough memory: True
INFO:qn9080dk.tests/periph_rtc:Application has test: True
INFO:qn9080dk.tests/periph_rtc:Run compilation
INFO:qn9080dk.tests/periph_rtc:Run test
INFO:qn9080dk.tests/periph_rtc:Run test.flash
INFO:qn9080dk.tests/periph_rtc:Success

@benpicco benpicco merged commit e3558a4 into RIOT-OS:master Dec 6, 2020
@iosabi iosabi deleted the qn908x_rtc branch January 31, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iosabi @benpicco