cpu/qn908x: Fix triggering GPIO IRQ. #15568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
Area: cpu
benpicco
reviewed
Dec 6, 2020
The IRQ for each GPIO port needs to be enabled in the NVIC on top of enabling the corresponding bit in the GPIO port. This was not caught in tests before because I was testing with a larger stack of commits (including UART and timers) which also had this fix. Manually poking the GPIOs while using tests/periph_gpio now properly fires the interrupts.
iosabi
force-pushed
the
qn908x_gpio_int
branch
from
eb15254
to
ac4c4d6
Compare
benpicco
approved these changes
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The IRQ for each GPIO port needs to be enabled in the NVIC on top of
enabling the corresponding bit in the GPIO port.
This was not caught in tests before because I was testing with a larger
stack of commits (including UART and timers) which also had this fix.
Manually poking the GPIOs while using tests/periph_gpio now properly
fires the interrupts.
Testing procedure
make BOARD=qn9080dk -C tests/periph_gpio all flashManual verification in the terminal poking the GPIOs after a "init_int" command.
Issues/PRs references
This is part of #13852.