Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist/tools/headerguards: fix annotation for multiple patches per file #15749

Merged
merged 1 commit into from Jan 12, 2021
Merged

dist/tools/headerguards: fix annotation for multiple patches per file #15749

merged 1 commit into from Jan 12, 2021

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jan 12, 2021 •
edited

Contribution description

Fixes a problem in the annotation generation for the headerguard check where multiple patches in a file are only shown as one annotation.

Testing procedure

I provided a test commit that should now generate two annotations instead of one.

Issues/PRs references

Follow-up on #15746.
See #15747 (comment) ff.

@miri64 miri64 requested a review from aabadie January 12, 2021 14:06
@miri64 miri64 added Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Jan 12, 2021
aabadie
aabadie approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works better. ACK and please remove the unrelated commit.

@miri64 miri64 force-pushed the dist/fix/headerguards-multi-patch branch from dcb096f to b711515 Compare January 12, 2021 14:55
@miri64
Copy link
Member Author

miri64 commented Jan 12, 2021

Done.

@miri64 miri64 merged commit d5ec849 into RIOT-OS:master Jan 12, 2021
@miri64 miri64 deleted the dist/fix/headerguards-multi-patch branch January 12, 2021 16:22
@miri64
Copy link
Member Author

miri64 commented Jan 12, 2021

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miri64 @aabadie