Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/testbed: use IOTLAB_NODE=auto instead of auto-ssh #16491

Merged
merged 3 commits into from May 28, 2021

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented May 21, 2021

Contribution description

This PR ticks the item in #9694 which is about merging auto and auto-ssh possible values for IOTLAB_NODE. As said by @cladmi, since there's an IOT_LAB_FRONTEND_FQDN env variable on the frontend there's no need to distinguish between auto and auto-ssh.
This makes the usage of IOTLAB_NODE more simple as well as cleaning up the internal implementation.

This PR also adds a deprecation message when auto-ssh is uses.

Testing procedure

  • Start an experiment on IoT-LAB with several iotlab-m3 and a8-m3:
$ iotlab-experiment submit -d 120 -l saclay,a8,110 -l grenoble,m3,20-31 -l saclay,m3,1-2
  • Build and flash an application for the M3, use auto to select one automatically (the first one in grenoble is used):
$ BUILD_IN_DOCKER=1 make -C examples/default BOARD=iotlab-m3 IOTLAB_NODE=auto flash term --no-print-directory 
Launching build container using image "riot/riotbuild:latest".
docker run --rm --tty --user $(id -u) -v '/usr/share/zoneinfo/Europe/Paris:/etc/localtime:ro' -v '/work/riot/RIOT:/data/riotbuild/riotbase:delegated' -e 'RIOTBASE=/data/riotbuild/riotbase' -e 'CCACHE_BASEDIR=/data/riotbuild/riotbase' -e 'BUILD_DIR=/data/riotbuild/riotbase/build' -e 'RIOTPROJECT=/data/riotbuild/riotbase' -e 'RIOTCPU=/data/riotbuild/riotbase/cpu' -e 'RIOTBOARD=/data/riotbuild/riotbase/boards' -e 'RIOTMAKE=/data/riotbuild/riotbase/makefiles'      -e 'BOARD=iotlab-m3'  -w '/data/riotbuild/riotbase/examples/default/' 'riot/riotbuild:latest' make 'BOARD=iotlab-m3'    
Building application "default" for "iotlab-m3" with MCU "stm32".

"make" -C /data/riotbuild/riotbase/boards/iotlab-m3
"make" -C /data/riotbuild/riotbase/boards/common/iotlab
"make" -C /data/riotbuild/riotbase/core
"make" -C /data/riotbuild/riotbase/cpu/stm32
"make" -C /data/riotbuild/riotbase/cpu/cortexm_common
"make" -C /data/riotbuild/riotbase/cpu/cortexm_common/periph
"make" -C /data/riotbuild/riotbase/cpu/stm32/periph
"make" -C /data/riotbuild/riotbase/cpu/stm32/stmclk
"make" -C /data/riotbuild/riotbase/cpu/stm32/vectors
"make" -C /data/riotbuild/riotbase/drivers
"make" -C /data/riotbuild/riotbase/drivers/at86rf2xx
"make" -C /data/riotbuild/riotbase/drivers/isl29020
"make" -C /data/riotbuild/riotbase/drivers/l3g4200d
"make" -C /data/riotbuild/riotbase/drivers/lpsxxx
"make" -C /data/riotbuild/riotbase/drivers/lsm303dlhc
"make" -C /data/riotbuild/riotbase/drivers/netdev
"make" -C /data/riotbuild/riotbase/drivers/periph_common
"make" -C /data/riotbuild/riotbase/drivers/saul
"make" -C /data/riotbuild/riotbase/drivers/saul/init_devs
"make" -C /data/riotbuild/riotbase/sys
"make" -C /data/riotbuild/riotbase/sys/auto_init
"make" -C /data/riotbuild/riotbase/sys/div
"make" -C /data/riotbuild/riotbase/sys/fmt
"make" -C /data/riotbuild/riotbase/sys/isrpipe
"make" -C /data/riotbuild/riotbase/sys/luid
"make" -C /data/riotbuild/riotbase/sys/malloc_thread_safe
"make" -C /data/riotbuild/riotbase/sys/net/gnrc
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netapi
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netif
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netif/hdr
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netif/ieee802154
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netif/init_devs
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netreg
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pkt
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pktbuf
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pktbuf_static
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pktdump
"make" -C /data/riotbuild/riotbase/sys/net/link_layer/eui_provider
"make" -C /data/riotbuild/riotbase/sys/net/link_layer/ieee802154
"make" -C /data/riotbuild/riotbase/sys/net/link_layer/l2util
"make" -C /data/riotbuild/riotbase/sys/net/netif
"make" -C /data/riotbuild/riotbase/sys/newlib_syscalls_default
"make" -C /data/riotbuild/riotbase/sys/od
"make" -C /data/riotbuild/riotbase/sys/phydat
"make" -C /data/riotbuild/riotbase/sys/pm_layered
"make" -C /data/riotbuild/riotbase/sys/ps
"make" -C /data/riotbuild/riotbase/sys/random
"make" -C /data/riotbuild/riotbase/sys/random/tinymt32
"make" -C /data/riotbuild/riotbase/sys/saul_reg
"make" -C /data/riotbuild/riotbase/sys/shell
"make" -C /data/riotbuild/riotbase/sys/shell/commands
"make" -C /data/riotbuild/riotbase/sys/stdio_uart
"make" -C /data/riotbuild/riotbase/sys/tsrb
"make" -C /data/riotbuild/riotbase/sys/xtimer
   text	   data	    bss	    dec	    hex	filename
  47292	    136	   6028	  53456	   d0d0	/data/riotbuild/riotbase/examples/default/bin/iotlab-m3/default.elf
iotlab-node --jmespath='keys(@)[0]' --format='lambda ret: exit(int(ret))'  --list grenoble,m3,20 --flash /work/riot/RIOT/examples/default/bin/iotlab-m3/default.bin
ssh -t abadie@grenoble.iot-lab.info 'socat - tcp:m3-20.grenoble.iot-lab.info:20000' 
help
help
Command              Description
---------------------------------------
reboot               Reboot the node
version              Prints current RIOT_VERSION
pm                   interact with layered PM subsystem
ps                   Prints information about running threads.
random_init          initializes the PRNG
random_get           returns 32 bit of pseudo randomness
rtc                  control RTC peripheral interface
ifconfig             Configure network interfaces
txtsnd               Sends a custom string as is over the link layer
saul                 interact with sensors and actuators using SAUL
> reboot
reboot
[auto_init_saul] error initializing l3g4200d #0
[auto_init_saul] error initializing lps331ap #0
[auto_init_saul] error initializing lsm303dlhc #0
main(): This is RIOT! (Version: 2021.07-devel-246-g22dec-pr/tools/iotlab_deprecate_auto_ssh)
Welcome to RIOT!
> ^CConnection to grenoble.iot-lab.info closed.
  • Build and flash an application for the M3, use the hostname to select one specifically in saclay:
$ BUILD_IN_DOCKER=1 make -C examples/default BOARD=iotlab-m3 IOTLAB_NODE=m3-1.saclay.iot-lab.info flash term --no-print-directory 
Launching build container using image "riot/riotbuild:latest".
docker run --rm --tty --user $(id -u) -v '/usr/share/zoneinfo/Europe/Paris:/etc/localtime:ro' -v '/work/riot/RIOT:/data/riotbuild/riotbase:delegated' -e 'RIOTBASE=/data/riotbuild/riotbase' -e 'CCACHE_BASEDIR=/data/riotbuild/riotbase' -e 'BUILD_DIR=/data/riotbuild/riotbase/build' -e 'RIOTPROJECT=/data/riotbuild/riotbase' -e 'RIOTCPU=/data/riotbuild/riotbase/cpu' -e 'RIOTBOARD=/data/riotbuild/riotbase/boards' -e 'RIOTMAKE=/data/riotbuild/riotbase/makefiles'      -e 'BOARD=iotlab-m3'  -w '/data/riotbuild/riotbase/examples/default/' 'riot/riotbuild:latest' make 'BOARD=iotlab-m3'    
Building application "default" for "iotlab-m3" with MCU "stm32".

"make" -C /data/riotbuild/riotbase/boards/iotlab-m3
"make" -C /data/riotbuild/riotbase/boards/common/iotlab
"make" -C /data/riotbuild/riotbase/core
"make" -C /data/riotbuild/riotbase/cpu/stm32
"make" -C /data/riotbuild/riotbase/cpu/cortexm_common
"make" -C /data/riotbuild/riotbase/cpu/cortexm_common/periph
"make" -C /data/riotbuild/riotbase/cpu/stm32/periph
"make" -C /data/riotbuild/riotbase/cpu/stm32/stmclk
"make" -C /data/riotbuild/riotbase/cpu/stm32/vectors
"make" -C /data/riotbuild/riotbase/drivers
"make" -C /data/riotbuild/riotbase/drivers/at86rf2xx
"make" -C /data/riotbuild/riotbase/drivers/isl29020
"make" -C /data/riotbuild/riotbase/drivers/l3g4200d
"make" -C /data/riotbuild/riotbase/drivers/lpsxxx
"make" -C /data/riotbuild/riotbase/drivers/lsm303dlhc
"make" -C /data/riotbuild/riotbase/drivers/netdev
"make" -C /data/riotbuild/riotbase/drivers/periph_common
"make" -C /data/riotbuild/riotbase/drivers/saul
"make" -C /data/riotbuild/riotbase/drivers/saul/init_devs
"make" -C /data/riotbuild/riotbase/sys
"make" -C /data/riotbuild/riotbase/sys/auto_init
"make" -C /data/riotbuild/riotbase/sys/div
"make" -C /data/riotbuild/riotbase/sys/fmt
"make" -C /data/riotbuild/riotbase/sys/isrpipe
"make" -C /data/riotbuild/riotbase/sys/luid
"make" -C /data/riotbuild/riotbase/sys/malloc_thread_safe
"make" -C /data/riotbuild/riotbase/sys/net/gnrc
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netapi
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netif
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netif/hdr
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netif/ieee802154
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netif/init_devs
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netreg
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pkt
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pktbuf
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pktbuf_static
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pktdump
"make" -C /data/riotbuild/riotbase/sys/net/link_layer/eui_provider
"make" -C /data/riotbuild/riotbase/sys/net/link_layer/ieee802154
"make" -C /data/riotbuild/riotbase/sys/net/link_layer/l2util
"make" -C /data/riotbuild/riotbase/sys/net/netif
"make" -C /data/riotbuild/riotbase/sys/newlib_syscalls_default
"make" -C /data/riotbuild/riotbase/sys/od
"make" -C /data/riotbuild/riotbase/sys/phydat
"make" -C /data/riotbuild/riotbase/sys/pm_layered
"make" -C /data/riotbuild/riotbase/sys/ps
"make" -C /data/riotbuild/riotbase/sys/random
"make" -C /data/riotbuild/riotbase/sys/random/tinymt32
"make" -C /data/riotbuild/riotbase/sys/saul_reg
"make" -C /data/riotbuild/riotbase/sys/shell
"make" -C /data/riotbuild/riotbase/sys/shell/commands
"make" -C /data/riotbuild/riotbase/sys/stdio_uart
"make" -C /data/riotbuild/riotbase/sys/tsrb
"make" -C /data/riotbuild/riotbase/sys/xtimer
   text	   data	    bss	    dec	    hex	filename
  47292	    136	   6028	  53456	   d0d0	/data/riotbuild/riotbase/examples/default/bin/iotlab-m3/default.elf
iotlab-node --jmespath='keys(@)[0]' --format='lambda ret: exit(int(ret))'  --list saclay,m3,1 --flash /work/riot/RIOT/examples/default/bin/iotlab-m3/default.bin
ssh -t abadie@saclay.iot-lab.info 'socat - tcp:m3-1.saclay.iot-lab.info:20000' 
help
help
Command              Description
---------------------------------------
reboot               Reboot the node
version              Prints current RIOT_VERSION
pm                   interact with layered PM subsystem
ps                   Prints information about running threads.
random_init          initializes the PRNG
random_get           returns 32 bit of pseudo randomness
rtc                  control RTC peripheral interface
ifconfig             Configure network interfaces
txtsnd               Sends a custom string as is over the link layer
saul                 interact with sensors and actuators using SAUL
> reboot
reboot
[auto_init_saul] error initializing l3g4200d #0
[auto_init_saul] error initializing lps331ap #0
[auto_init_saul] error initializing lsm303dlhc #0
main(): This is RIOT! (Version: 2021.07-devel-246-g22dec-pr/tools/iotlab_deprecate_auto_ssh)
Welcome to RIOT!
> ^CConnection to saclay.iot-lab.info closed.
  • Build and flash an application for the A8-M3, use the auto to select one automatically in saclay (you need version 1.0.2 of iotlabsshcli for this one to work because of a bug, well missing feature, when flashing .bin firmwares in earlier versions):
$ BUILD_IN_DOCKER=1 make -C examples/default BOARD=iotlab-a8-m3 IOTLAB_NODE=auto flash term --no-print-directory 
Launching build container using image "riot/riotbuild:latest".
docker run --rm --tty --user $(id -u) -v '/usr/share/zoneinfo/Europe/Paris:/etc/localtime:ro' -v '/work/riot/RIOT:/data/riotbuild/riotbase:delegated' -e 'RIOTBASE=/data/riotbuild/riotbase' -e 'CCACHE_BASEDIR=/data/riotbuild/riotbase' -e 'BUILD_DIR=/data/riotbuild/riotbase/build' -e 'RIOTPROJECT=/data/riotbuild/riotbase' -e 'RIOTCPU=/data/riotbuild/riotbase/cpu' -e 'RIOTBOARD=/data/riotbuild/riotbase/boards' -e 'RIOTMAKE=/data/riotbuild/riotbase/makefiles'      -e 'BOARD=iotlab-a8-m3'  -w '/data/riotbuild/riotbase/examples/default/' 'riot/riotbuild:latest' make 'BOARD=iotlab-a8-m3'    
Building application "default" for "iotlab-a8-m3" with MCU "stm32".

"make" -C /data/riotbuild/riotbase/boards/iotlab-a8-m3
"make" -C /data/riotbuild/riotbase/boards/common/iotlab
"make" -C /data/riotbuild/riotbase/core
"make" -C /data/riotbuild/riotbase/cpu/stm32
"make" -C /data/riotbuild/riotbase/cpu/cortexm_common
"make" -C /data/riotbuild/riotbase/cpu/cortexm_common/periph
"make" -C /data/riotbuild/riotbase/cpu/stm32/periph
"make" -C /data/riotbuild/riotbase/cpu/stm32/stmclk
"make" -C /data/riotbuild/riotbase/cpu/stm32/vectors
"make" -C /data/riotbuild/riotbase/drivers
"make" -C /data/riotbuild/riotbase/drivers/at86rf2xx
"make" -C /data/riotbuild/riotbase/drivers/l3g4200d
"make" -C /data/riotbuild/riotbase/drivers/lsm303dlhc
"make" -C /data/riotbuild/riotbase/drivers/netdev
"make" -C /data/riotbuild/riotbase/drivers/periph_common
"make" -C /data/riotbuild/riotbase/drivers/saul
"make" -C /data/riotbuild/riotbase/drivers/saul/init_devs
"make" -C /data/riotbuild/riotbase/sys
"make" -C /data/riotbuild/riotbase/sys/auto_init
"make" -C /data/riotbuild/riotbase/sys/div
"make" -C /data/riotbuild/riotbase/sys/fmt
"make" -C /data/riotbuild/riotbase/sys/isrpipe
"make" -C /data/riotbuild/riotbase/sys/luid
"make" -C /data/riotbuild/riotbase/sys/malloc_thread_safe
"make" -C /data/riotbuild/riotbase/sys/net/gnrc
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netapi
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netif
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netif/hdr
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netif/ieee802154
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netif/init_devs
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netreg
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pkt
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pktbuf
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pktbuf_static
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pktdump
"make" -C /data/riotbuild/riotbase/sys/net/link_layer/eui_provider
"make" -C /data/riotbuild/riotbase/sys/net/link_layer/ieee802154
"make" -C /data/riotbuild/riotbase/sys/net/link_layer/l2util
"make" -C /data/riotbuild/riotbase/sys/net/netif
"make" -C /data/riotbuild/riotbase/sys/newlib_syscalls_default
"make" -C /data/riotbuild/riotbase/sys/od
"make" -C /data/riotbuild/riotbase/sys/phydat
"make" -C /data/riotbuild/riotbase/sys/pm_layered
"make" -C /data/riotbuild/riotbase/sys/ps
"make" -C /data/riotbuild/riotbase/sys/random
"make" -C /data/riotbuild/riotbase/sys/random/tinymt32
"make" -C /data/riotbuild/riotbase/sys/saul_reg
"make" -C /data/riotbuild/riotbase/sys/shell
"make" -C /data/riotbuild/riotbase/sys/shell/commands
"make" -C /data/riotbuild/riotbase/sys/stdio_uart
"make" -C /data/riotbuild/riotbase/sys/tsrb
"make" -C /data/riotbuild/riotbase/sys/xtimer
   text	   data	    bss	    dec	    hex	filename
  45024	    136	   5956	  51116	   c7ac	/data/riotbuild/riotbase/examples/default/bin/iotlab-a8-m3/default.elf
iotlab-ssh --jmespath='keys(values(@)[0])[0]' --fmt='int'  flash-m3 --list saclay,a8,110 /work/riot/RIOT/examples/default/bin/iotlab-a8-m3/default.bin
sys:1: DeprecationWarning: flash-m3 command is deprecated and will be removed in next release. Please use flash instead.


0
ssh -oProxyCommand='ssh abadie@saclay.iot-lab.info -W %h:%p' -oStrictHostKeyChecking=no -t root@node-a8-110.saclay.iot-lab.info 'socat - open:/dev/ttyA8_M3,b500000,echo=0,raw' 
help
help
Command              Description
---------------------------------------
reboot               Reboot the node
version              Prints current RIOT_VERSION
pm                   interact with layered PM subsystem
ps                   Prints information about running threads.
random_init          initializes the PRNG
random_get           returns 32 bit of pseudo randomness
rtc                  control RTC peripheral interface
ifconfig             Configure network interfaces
txtsnd               Sends a custom string as is over the link layer
saul                 interact with sensors and actuators using SAUL
> reboot
reboot
main(): This is RIOT! (Version: 2021.07-devel-246-g22dec-pr/tools/iotlab_deprecate_auto_ssh)
Welcome to RIOT!
> ^CConnection to node-a8-110.saclay.iot-lab.info closed.

This PR also works when the commands above are launched from an IoT-LAB SSH frontend (except the one for A8-M3 because of the bug about .bin firmwares that is fixed in version 1.0.2 of iotlab-ssh but not released on the frontends).

Issues/PRs references

Tick one item in #9694

@github-actions github-actions bot added the Area: tools Area: Supplementary tools label May 21, 2021
@aabadie aabadie added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label May 22, 2021
@aabadie
Copy link
Contributor Author

aabadie commented May 22, 2021

There's something with this PR, I'll rework it a bit. Marking it as WIP.

@aabadie aabadie force-pushed the pr/tools/iotlab_deprecate_auto_ssh branch from 22dec0b to 8d4cf6e Compare May 22, 2021 07:25
@aabadie
Copy link
Contributor Author

aabadie commented May 22, 2021

I could fix the problem easily. This is not WIP anymore :)

@aabadie aabadie removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label May 22, 2021
@aabadie aabadie force-pushed the pr/tools/iotlab_deprecate_auto_ssh branch 3 times, most recently from 29c7183 to d2325b8 Compare May 22, 2021 09:52
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels May 22, 2021
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First comments

@@ -48,6 +48,11 @@ ifeq (,$(IOTLAB_NODE))
$(error)
endif

ifeq (auto-ssh,$(IOTLAB_NODE))
$(warning IOTLAB_NODE=auto-ssh is deprecated, use IOTLAB_NODE=auto instead)
override IOTLAB_NODE := auto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is override needed? I would be needed only if is set as a MAKE argument.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, IOTLAB_NODE is already overridden in master. Otherwise it won't work with a command like make IOTLAB_NODE=auto

@@ -48,6 +48,11 @@ ifeq (,$(IOTLAB_NODE))
$(error)
endif

ifeq (auto-ssh,$(IOTLAB_NODE))
$(warning IOTLAB_NODE=auto-ssh is deprecated, use IOTLAB_NODE=auto instead)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a deprecation date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and improved with a colored message.

@fjmolinas fjmolinas added the Process: deprecation Integration Process: The PR is deprecating a feature or API label May 26, 2021
@aabadie aabadie force-pushed the pr/tools/iotlab_deprecate_auto_ssh branch from d2325b8 to b39b07d Compare May 26, 2021 09:27
@aabadie
Copy link
Contributor Author

aabadie commented May 28, 2021

@fjmolinas, may I squash ?

Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thre is a reference in tests/pkg_semtech-loramac/README.md and examples/lorawan/README.md and .github/workflows/test-on-iotlab.yml uses the deprecated version.

# IOTLAB_NODE=auto or auto-ssh
should also be adapted

@fjmolinas
Copy link
Contributor

Verified the testing procedure locally and on the frontend.

@fjmolinas fjmolinas added the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label May 28, 2021
@fjmolinas
Copy link
Contributor

Thre is a reference in tests/pkg_semtech-loramac/README.md and examples/lorawan/README.md and .github/workflows/test-on-iotlab.yml uses the deprecated version.

# IOTLAB_NODE=auto or auto-ssh

should also be adapted

Please squash once addressed.

@aabadie aabadie force-pushed the pr/tools/iotlab_deprecate_auto_ssh branch from bed3e8d to d42ac48 Compare May 28, 2021 15:22
@github-actions github-actions bot added Area: CI Area: Continuous Integration of RIOT components Area: examples Area: Example Applications Area: tests Area: tests and testing framework labels May 28, 2021
This deprecates the use of IOTLAB_NODE=auto-ssh
@aabadie aabadie force-pushed the pr/tools/iotlab_deprecate_auto_ssh branch from d42ac48 to 12a03c6 Compare May 28, 2021 15:23
@aabadie
Copy link
Contributor Author

aabadie commented May 28, 2021

Removed the remaining occurrences of auto-ssh and squashed!

Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aabadie aabadie merged commit 64c7332 into RIOT-OS:master May 28, 2021
@aabadie aabadie deleted the pr/tools/iotlab_deprecate_auto_ssh branch May 28, 2021 17:23
@jeandudey jeandudey added this to the Release 2021.07 milestone May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CI Area: Continuous Integration of RIOT components Area: examples Area: Example Applications Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: deprecation Integration Process: The PR is deprecating a feature or API Reviewed: 3-testing The PR was tested according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants