Makefile.include: enable verbose asserts with DEVELHELP=2

[benpicco]

Contribution description

Verbose asserts can be useful, but I always forget how to enable them.
To ease use, add a second level to the DEVELHELP option that can be used to enable more 'expensive' helpers.

Testing procedure

Issues/PRs references

[kaspar030]

My gut feeling is that it is not a good idea to change DEVELHELP values from (0,1) to (0,1,2).

[chrysn]

Just for context, is the intention that DEVELHELP=2 would enable DEBUG_ASSERT_VERBOSE? I find that easier to understand than overloading DEVELHELP which already does a lot of things.

As for discoverability, I see potential for enhancement -- maybe DEBUG_ASSERT_VERBOSE could be grouped in the docs in the utilities group next to DEVELHELP? Then it'd show up right next when looking up what DEVELHELP is doing.

[benpicco]

I thought it might be similar to how some tools have multiple levels of verbosity -v, -vv, …

[fjmolinas]

How about as a first step add

Suggested change

	ifeq (2, $(DEVELHELP))
	CFLAGS += -DDEBUG_ASSERT_VERBOSE
	endif
	DEBUG_ASSERT_VERBOSE ?=0
	ifeq ($(DEBUG_ASSERT_VERBOSE),1)
	CFLAGS += -DDEBUG_ASSERT_VERBOSE
	endif

[maribu]

That would already be quite helpful. Maybe even a shorter name, e.g. VERBOSE_ASSERT or ASSERT_VERBOSE, as this is often typed by hand?

[benpicco]

closed in favor of #16884