tools/pythonlibs/riotctrl_*: add code format check with black #16915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
Type: cleanup
github-actions
bot
added
Area: tests
aabadie
added
the
CI: ready for build
|
Should we skip string-normalization here? |
Add Flake8 configuration compatible with black
Add Flake8 configuration compatible with black
They are already covered by flake8 with their tox configuration
aabadie
force-pushed
the
pr/pythonlibs/black_format
branch
from
1fbc949
to
2e7c83f
Compare
|
ping @fjmolinas |
|
@fjmolinas care to ACK this one ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR applies the black automatic code formater to riotctrl pythonlibs, similar to #16907 and #16905.
I couldn't a better solution on how to call black from the tox env. When black is called directly, the files with
pyare taken into account by default and specifying*.py, returns an error. Wrapping the call in bash works (only solution I found).There's room to use f-strings in this code but it's not part of this PR.
Testing procedure
Green CI
Issues/PRs references
similar to #16907 and #16905