Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riotboot_dfu: use ztimer instead of xtimer #17051

Merged
merged 4 commits into from Oct 26, 2021
Merged

riotboot_dfu: use ztimer instead of xtimer #17051

merged 4 commits into from Oct 26, 2021

Conversation

bergzand
Copy link
Member

Contribution description

Use ztimer isntead of xtimer for riotboot_dfu.

Testing procedure

The DFU bootloader, especially the reboot functionality should still work.

Issues/PRs references

None

@github-actions github-actions bot added Area: sys Area: System Area: timers Area: timer subsystems Area: USB Area: Universal Serial Bus labels Oct 25, 2021
@bergzand bergzand mentioned this pull request Oct 25, 2021
Merged
@bergzand bergzand added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 25, 2021
kaspar030
kaspar030 reviewed Oct 26, 2021
View reviewed changes
sys/usb/usbus/dfu/dfu.c Outdated Show resolved Hide resolved
@kaspar030 kaspar030 added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Oct 26, 2021
@kaspar030
Copy link
Contributor

LGTM, didn't test.

@kaspar030
Copy link
Contributor

But I think you can squash the current state!

@bergzand
Copy link
Member Author

Squashed!

dylad
dylad approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.
Worked as expected, dfu-util still shows the same output on both this PR and master with same54-xpro

@dylad dylad added the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label Oct 26, 2021
@dylad dylad added this to the Release 2022.01 milestone Oct 26, 2021
@dylad dylad merged commit aa43831 into RIOT-OS:master Oct 26, 2021
@bergzand bergzand deleted the pr/riotboot_dfu/ztimer branch October 27, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 left review comments

@dylad dylad dylad approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

Assignees
No one assigned
Labels
Area: sys Area: System Area: timers Area: timer subsystems Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bergzand @kaspar030 @dylad