Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/openthread: migrate to ztimer #17120

Merged
merged 1 commit into from Nov 24, 2021

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Nov 3, 2021

Contribution description

This PR migrates the openthread package to ztimer (using msec). It's quite straight forward.

Testing procedure

  • Green CI
  • examples/openthread is still working (untested yet)

Issues/PRs references

@aabadie aabadie requested a review from jia200x as a code owner November 3, 2021 09:20
@github-actions github-actions bot added Area: network Area: Networking Area: pkg Area: External package ports labels Nov 3, 2021
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 3, 2021
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Nov 18, 2021
@aabadie aabadie force-pushed the pr/pkg/openthread_ztimer branch 2 times, most recently from f09defe to e8cfd49 Compare November 23, 2021 08:25
@aabadie
Copy link
Contributor Author

aabadie commented Nov 24, 2021

Some output of this PR with M3 from IoT-LAB Grenoble:

abadie@grenoble:~$ serial_aggregator 
1637758683.703259;Aggregator started
# Only M3-2 and M3-7 are up at the beginning:
1637758809.125899;m3-2;main(): This is RIOT! (Version: 2022.01-devel-701-ge8cf-pr/pkg/openthread_ztimer)
1637758809.126672;m3-2;This is an OpenThread example
1637758809.126855;m3-2;Current panid: 0xbeef
1637758809.273554;m3-7;main(): This is RIOT! (Version: 2022.01-devel-701-ge8cf-pr/pkg/openthread_ztimer)
1637758809.273821;m3-7;This is an OpenThread example
1637758809.274288;m3-7;Current panid: 0xbeef

# just after flashing m3-2 and m3-7, m3-7 is the leader while m3-2 is a child
state
1637758826.628359;m3-2;state
1637758826.628623;m3-2;child
1637758826.628777;m3-2;Done
1637758826.629876;m3-7;state
1637758826.629969;m3-7;leader
1637758826.630046;m3-7;Done

# after some time, m3-2 becomes a router:
state
1637758945.561238;m3-7;> state
1637758945.562017;m3-2;> state
1637758945.562158;m3-2;router
1637758945.562260;m3-2;Done
1637758945.562376;m3-7;leader
1637758945.562476;m3-7;Done


# Start other nodes and flash them:
1637758950.418210;m3-17;> main(): This is RIOT! (Version: 2022.01-devel-701-ge8cf-pr/pkg/openthread_ztimer)
1637758950.419097;m3-17;This is an OpenThread example
1637758950.419246;m3-17;Current panid: 0xbeef
1637758950.483492;m3-30;> main(): This is RIOT! (Version: 2022.01-devel-701-ge8cf-pr/pkg/openthread_ztimer)
1637758950.483756;m3-30;This is an OpenThread example
1637758950.484228;m3-30;Current panid: 0xbeef
1637758950.576080;m3-12;> main(): This is RIOT! (Version: 2022.01-devel-701-ge8cf-pr/pkg/openthread_ztimer)
1637758950.576304;m3-12;This is an OpenThread example
1637758950.576870;m3-12;Current panid: 0xbeef

# After some time, all but m3-7 (leader) are routers:
state
1637759121.583709;m3-2;> state
1637759121.584006;m3-2;router
1637759121.584126;m3-2;Done
1637759121.584483;m3-30;state
1637759121.584617;m3-7;> state
1637759121.584717;m3-7;leader
1637759121.584801;m3-7;Done
1637759121.584942;m3-17;state
1637759121.585032;m3-17;router
1637759121.585156;m3-17;Done
1637759121.585295;m3-12;state
1637759121.585380;m3-12;router
1637759121.585495;m3-12;Done
1637759121.585810;m3-30;router
1637759121.585916;m3-30;Done

# ping works:
ipaddr
1637759160.088879;m3-17;> ipaddr
1637759160.089174;m3-30;> ipaddr
1637759160.089501;m3-7;> ipaddr
1637759160.089622;m3-7;fdde:ad00:beef:0:0:ff:fe00:fc00
1637759160.089874;m3-12;> ipaddr
1637759160.090003;m3-17;fdde:ad00:beef:0:0:ff:fe00:8800
1637759160.090111;m3-2;> ipaddr
1637759160.090265;m3-2;fdde:ad00:beef:0:0:ff:fe00:e800
1637759160.090410;m3-2;fdde:ad00:beef:0:58f7:e012:4943:8d
1637759160.090519;m3-30;fdde:ad00:beef:0:0:ff:fe00:ec00
1637759160.090638;m3-30;fdde:ad00:beef:0:55f:8f06:8092:35c8
1637759160.090778;m3-17;fdde:ad00:beef:0:3872:ef0c:e27:2db
1637759160.090881;m3-2;fe80:0:0:0:34cf:5229:d4a7:453b
1637759160.090973;m3-2;Done
1637759160.091084;m3-7;fdde:ad00:beef:0:0:ff:fe00:cc00
1637759160.091345;m3-12;fdde:ad00:beef:0:0:ff:fe00:3800
1637759160.091439;m3-12;fdde:ad00:beef:0:746d:761a:c012:ec7e
1637759160.091589;m3-30;fe80:0:0:0:ec09:a34c:e703:11d9
1637759160.091683;m3-30;Done
1637759160.091783;m3-7;fdde:ad00:beef:0:fdb0:4fb9:9896:8e3b
1637759160.091915;m3-17;fe80:0:0:0:6479:52ac:ff2:a8b2
1637759160.091997;m3-17;Done
1637759160.092300;m3-7;fe80:0:0:0:54a9:cd8c:4322:85e3
1637759160.092421;m3-7;Done
1637759160.092637;m3-12;fe80:0:0:0:d8c6:f947:48e8:3a3f
1637759160.092731;m3-12;Done
m3-2;ping fdde:ad00:beef:0:0:ff:fe00:ec00
1637759173.750178;m3-2;> ping fdde:ad00:beef:0:0:ff:fe00:ec00
1637759173.750426;m3-2;Done
1637759173.774060;m3-2;> 16 bytes from fdde:ad00:beef:0:0:ff:fe00:ec00: icmp_seq=1 hlim=64 time=23ms

@fjmolinas
Copy link
Contributor

@jia200x is the test output enough for you?

@jia200x
Copy link
Member

jia200x commented Nov 24, 2021

yes! it makes sense

Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, test output is provided

@aabadie aabadie merged commit 97758b8 into RIOT-OS:master Nov 24, 2021
@aabadie aabadie deleted the pr/pkg/openthread_ztimer branch November 24, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants