Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/nrf51: model kconfig #17274

Merged
merged 8 commits into from Nov 26, 2021
Merged

cpu/nrf51: model kconfig #17274

merged 8 commits into from Nov 26, 2021

Conversation

fjmolinas
Copy link
Contributor

Contribution description

This models the Kconfig modules for all boards based on nrf51. The CI is set to test only this on microbit for now. Some changes on drivers are also included here (mostly adding hardware features to indicate presence).

Testing procedure

  • Green CI
  • Check the modelling and compare make info-modules list with and without TEST_KCONFIG=1, they should match.

Issues/PRs references

Part of #16875

@fjmolinas fjmolinas mentioned this pull request Nov 25, 2021
Closed
@github-actions github-actions bot added Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework labels Nov 25, 2021
@leandrolanzieri
Copy link
Contributor

@fjmolinas thanks for tackling this one! Do you think you could add a REMOVEME commit like this one dd8c2b7 to quickly check all boards?

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines labels Nov 25, 2021
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 25, 2021
@github-actions github-actions bot added the Area: doc Area: Documentation label Nov 26, 2021
fjmolinas
fjmolinas commented Nov 26, 2021
View reviewed changes
boards/calliope-mini/Makefile.dep
USEMODULE += bmx055
endif

include $(RIOTBOARD)/common/microbit/Makefile.dep
include $(RIOTBOARD)/common/nrf51/Makefile.dep
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I need to split this one...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitted and added to makefile.ci

@github-actions github-actions bot added the Area: examples Area: Example Applications label Nov 26, 2021
@leandrolanzieri leandrolanzieri moved this from In progress to Review in progress in [CTF] Kconfig migration - Model of module dependencies Nov 26, 2021
@fjmolinas
Copy link
Contributor Author

All green here @leandrolanzieri ?

@fjmolinas
Copy link
Contributor Author

All green here @leandrolanzieri ?

Shall I squash and remove the REMOVEME?

@leandrolanzieri
Copy link
Contributor

Please go ahead @fjmolinas

leandrolanzieri
leandrolanzieri approved these changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green! ACK

[CTF] Kconfig migration - Model of module dependencies automation moved this from Review in progress to Reviewer approved Nov 26, 2021
@leandrolanzieri leandrolanzieri added Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Nov 26, 2021
@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Nov 26, 2021
@leandrolanzieri leandrolanzieri merged commit d962787 into RIOT-OS:master Nov 26, 2021
[CTF] Kconfig migration - Model of module dependencies automation moved this from Reviewer approved to Done Nov 26, 2021
@fjmolinas fjmolinas deleted the pr_kconfig_nrf51 branch November 26, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie left review comments

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@smlng smlng Awaiting requested review from smlng

@miri64 miri64 Awaiting requested review from miri64

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: doc Area: Documentation Area: drivers Area: Device drivers Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines
Projects
[CTF] Kconfig migration - Model of mo...
  
Done
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fjmolinas @leandrolanzieri @aabadie