sys/ztimer/kconfig: enable xtimer compat only with timer backend #17307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrolanzieri
added
the
Type: bug
leandrolanzieri
added this to In progress
in [CTF] Kconfig migration - Model of module dependencies
via automation
github-actions
bot
added
Area: arduino API
[CTF] Kconfig migration - Model of module dependencies
automation
moved this from In progress
to Reviewer approved
Dec 2, 2021
fjmolinas
added
the
CI: ready for build
|
#17317 is merged, it needs probably an update |
leandrolanzieri
force-pushed
the
pr/sys/ztimer/kconfig/fix_compat_deps
branch
from
b9a0b78
to
004da59
Compare
|
There, updated the |
This also moves the selection of MODULE_ZTIMER_PERIPH_TIMER from MODULE_ZTIMER_USEC to the visible symbol ZTIMER_USEC.
|
ACK still stands |
[CTF] Kconfig migration - Model of module dependencies
automation
moved this from Reviewer approved
to Done
Dec 2, 2021
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
While testing #17235 I came across a discrepancy between when
Makefile.depenables xtimer compatibility modules and when Kconfig does it. Kconfig would enable compatibility whenever xtimer and ztimer are active, butMakefile.depchecks in addition that the timer peripheral backend is enabled. This PR adds this condition to the Kconfig choice. To avoid a loop on the selection of MODULE_ZTIMER_PERIPH_TIMER, this also moves its selection from MODULE_ZTIMER_USEC to the visible symbol ZTIMER_USEC.Testing procedure
Makefile.dep.Issues/PRs references
#17235