Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/stm32: migrate adc and eth periphs to ztimer #17320

Merged
merged 2 commits into from Dec 2, 2021
Merged

cpu/stm32: migrate adc and eth periphs to ztimer #17320

merged 2 commits into from Dec 2, 2021

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Dec 2, 2021

Contribution description

As the title says. I should be able to provide some test output tomorrow.

Testing procedure

  • Green CI
  • Ethernet still working
  • ADC still working on F3 and L4

Issues/PRs references

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 2, 2021
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Dec 2, 2021
@maribu maribu added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Dec 2, 2021
@maribu
Copy link
Member

maribu commented Dec 2, 2021

Code looks good and the link status detection in the Ethernet driver (if module stm32_eth_link_up is used, obviously) still works.

@maribu
Copy link
Member

maribu commented Dec 2, 2021

tests/periph_adc on a Nucleo-F303RE gives reasonable output for both 0V and 3.3V on each ADC line

@maribu maribu added the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label Dec 2, 2021
@maribu maribu enabled auto-merge December 2, 2021 12:05
@aabadie
Copy link
Contributor Author

aabadie commented Dec 2, 2021

Thanks for testing @maribu :)

@github-actions github-actions bot added the Area: Kconfig Area: Kconfig integration label Dec 2, 2021
@aabadie
Copy link
Contributor Author

aabadie commented Dec 2, 2021

@maribu I (force) pushed one last commit about modeling the ADC periph dependency with Kconfig, which I forgot initially.

@aabadie aabadie mentioned this pull request Dec 2, 2021
Merged
@maribu maribu merged commit ec39b8e into RIOT-OS:master Dec 2, 2021
@aabadie aabadie deleted the pr/cpu/stm32_ztimer branch December 3, 2021 09:54
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@DipSwitch DipSwitch Awaiting requested review from DipSwitch

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aabadie @maribu @fjmolinas