New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/kinetis/include: fix xtimer backend timer selection #17393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjmolinas
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Dec 14, 2021
fjmolinas
requested review from
aabadie,
kaspar030,
leandrolanzieri,
MichelRottleuthner and
smlng
as code owners
December 14, 2021 12:24
github-actions
bot
added
Area: cpu
Area: CPU/MCU ports
Area: sys
Area: System
Area: tests
Area: tests and testing framework
Area: timers
Area: timer subsystems
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
labels
Dec 14, 2021
kaspar030
reviewed
Dec 14, 2021
kaspar030
reviewed
Dec 14, 2021
waiting for #17394 |
fjmolinas
force-pushed
the
pr_kinetis_fix_rtt
branch
from
December 14, 2021 17:16
9427027
to
bf05468
Compare
github-actions
bot
removed
Area: sys
Area: System
Area: timers
Area: timer subsystems
labels
Dec 14, 2021
There is an unrelated failure... something wrong in master |
fjmolinas
added
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Dec 14, 2021
All green @kaspar030 I split the waiting commit out |
kaspar030
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: cpu
Area: CPU/MCU ports
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
While testing #17357 I had the test fail on
frdm-kw41z
, while investigating I realized there was a wrong define and that the rtt callback was not cleared.I also added a fix to the rtt_min_offset test which was not updated since now kinetis runs at 32khz.
Testing procedure
USEMODULE=evtimer_on_ztimer BOARD=frdm-kw41z make -C tests/evtimer_msg/ flash test -j
now passesBOARD=usb-kw41z make -C tests/periph_rtt_min/ flash term -j
default samples are used.