Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/kinetis/include: fix xtimer backend timer selection #17393

Merged
merged 3 commits into from Dec 14, 2021

Conversation

fjmolinas
Copy link
Contributor

Contribution description

While testing #17357 I had the test fail on frdm-kw41z, while investigating I realized there was a wrong define and that the rtt callback was not cleared.

I also added a fix to the rtt_min_offset test which was not updated since now kinetis runs at 32khz.

Testing procedure

USEMODULE=evtimer_on_ztimer BOARD=frdm-kw41z make -C tests/evtimer_msg/ flash test -j now passes

main(): This is RIOT! (Version: 2022.01-devel-1233-gbf0546-pr_kinetis_fix_rtt)
Testing generic evtimer
This should list 2 items
ev #1 offset=999
ev #2 offset=500
This should list 4 items
ev #1 offset=659
ev #2 offset=341
ev #3 offset=500
ev #4 offset=2454
Are the reception times of all 4 msgs close to the supposed values?
At   3854 ms received msg 0: "#2 supposed to be 3854"
.At   4195 ms received msg 1: "#0 supposed to be 4195"
.At   4695 ms received msg 2: "#1 supposed to be 4695"
.At   7149 ms received msg 3: "#3 supposed to be 7149"
.
All tests successful
  • BOARD=usb-kw41z make -C tests/periph_rtt_min/ flash term -j default samples are used.
START
main(): This is RIOT! (Version: 2022.01-devel-1233-gbf0546-pr_kinetis_fix_rtt)
Evaluate RTT_MIN_OFFSET over 1024 samples
Sample 0
Sample 1
Sample 2
....
Sample 1021
Sample 1022
Sample 1023

RTT_MIN_OFFSET for usb-kw41z over 1024 samples: 1

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 14, 2021
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: sys Area: System Area: tests Area: tests and testing framework Area: timers Area: timer subsystems Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Dec 14, 2021
@kaspar030
Copy link
Contributor

waiting for #17394

@github-actions github-actions bot removed Area: sys Area: System Area: timers Area: timer subsystems labels Dec 14, 2021
@fjmolinas
Copy link
Contributor Author

There is an unrelated failure... something wrong in master

@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 14, 2021
@fjmolinas
Copy link
Contributor Author

All green @kaspar030 I split the waiting commit out

Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 merged commit 29ed101 into RIOT-OS:master Dec 14, 2021
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Jan 21, 2022
@fjmolinas fjmolinas deleted the pr_kinetis_fix_rtt branch March 24, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants