Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/ztimer: ztimer_now() add warning regarding comparing now() values #17404

Merged
merged 1 commit into from Dec 15, 2021
Merged

sys/ztimer: ztimer_now() add warning regarding comparing now() values #17404

merged 1 commit into from Dec 15, 2021

Conversation

kaspar030
Copy link
Contributor

Contribution description

Add another warning to not compare ztimer_now() values from different clocks.

Testing procedure

Issues/PRs references

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Dec 15, 2021
@github-actions github-actions bot added Area: sys Area: System Area: timers Area: timer subsystems labels Dec 15, 2021
@kaspar030 kaspar030 mentioned this pull request Dec 15, 2021
Closed
@maribu maribu removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Dec 15, 2021
@maribu
Copy link
Member

maribu commented Dec 15, 2021

Wait, the doc is in a header file. I wanted to give the can_fast_compile.py a chance to detect this and realized now it wont :/

@maribu maribu added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 15, 2021
@kaspar030
Copy link
Contributor Author

Wait, the doc is in a header file. I wanted to give the can_fast_compile.py a chance to detect this and realized now it wont :/

this might fix this.

@kaspar030 kaspar030 merged commit a8ade82 into RIOT-OS:master Dec 15, 2021
@kaspar030 kaspar030 deleted the ztimer_clarify_now_comparisons branch December 15, 2021 14:44
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

Assignees
No one assigned
Labels
Area: sys Area: System Area: timers Area: timer subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kaspar030 @maribu @fjmolinas