Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp: integrate CPU clock frequency selection in Kconfig #17424

Merged
merged 3 commits into from Jan 4, 2022
Merged

cpu/esp: integrate CPU clock frequency selection in Kconfig #17424

merged 3 commits into from Jan 4, 2022

Conversation

gschorcht
Copy link
Contributor

Contribution description

As the title says, this PR integrates CPU clock frequency selection in Kconfig.

Futhermore, it contains a small fix which removes the duplicate of HAS_ESP_SPI_RAM feature definition (f01e080)

Testing procedure

  1. Compilation has to succeed.
  2. Use commands: 
    TEST_KCONFIG=1 make BOARD=esp32-wroom-32 -C tests/shell menuconfig
TEST_KCONFIG=1 make BOARD=esp8266-esp-12x -C tests/shell menuconfig
    The CPU clock frequency should be selectable in ESP32 and ESP8266 specific configurations.

Issues/PRs references

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Dec 19, 2021
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Dec 19, 2021
aabadie
aabadie approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good and I tested on esp32-wroom-32 with success.

ACK

@aabadie aabadie merged commit 1a3f2d9 into RIOT-OS:master Jan 4, 2022
@gschorcht
Copy link
Contributor Author

Thanks for reviewing, testing and merging.

@gschorcht gschorcht deleted the cpu/esp/kconfig_cpu_frequency branch January 4, 2022 13:13
@aabadie aabadie mentioned this pull request Jan 17, 2022
Merged
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gschorcht @aabadie @fjmolinas