boards: unify user button defines #17428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
the
Type: cleanup
kaspar030
reviewed
Dec 20, 2021
kaspar030
approved these changes
Dec 20, 2021
kaspar030
added
the
CI: ready for build
aabadie
force-pushed
the
pr/boards/unify_user_button_define
branch
from
e8d0a25
to
4877155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
There are a few boards that define there user button as
BTN_B1_PINwithout defining the GPIO mode. This is not compatible with thetests/buttonsapplication which expects the defines to be calledBTNx_PINandBTNx_MODE.This PR renamed these defines to make them compatible and testable with
tests/buttons.Testing procedure
tests/buttonsnow works withb-l072z-rwan1,b-l475e-iot01a,pyboardandublox-c030-u201.Issues/PRs references
Noticed that when working on #17410