Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/esp* and cpu/esp: feature definition cleanup #17438

Merged
merged 6 commits into from Jan 4, 2022
Merged

boards/esp* and cpu/esp: feature definition cleanup #17438

merged 6 commits into from Jan 4, 2022

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR moves the definitions of the peripheral features to cpu/esp_common that are common for all ESP boards and usually defined by the CPU of all other platforms.

The following features are usually defined by the CPU for all other platforms:

periph_gpio
periph_gpio_irq
periph_uart_mode_cfg

Since they are common for all ESP SoC and boards, they are moved to cpu/esp_common. In addition, the following functions that are common to ESP SoCs are also moved to cpu/esp_common:

periph_rtc
periph_rtt
periph_rtt_overflow
periph_rtt_set_counter

Testing procedure

Green CI

Issues/PRs references

@github-actions github-actions bot added Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Dec 23, 2021
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Dec 23, 2021
aabadie
aabadie approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good and make sense. Murdock is green.

ACK

@aabadie aabadie merged commit 05da606 into RIOT-OS:master Jan 4, 2022
@gschorcht
Copy link
Contributor Author

Thanks for reviewing and merging.

@fjmolinas fjmolinas added this to the Release 2022.01 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gschorcht @aabadie @fjmolinas