Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: cpu: replace GPIO_UNDEF by SPI_CS_UNDEF in SPI configuration #17468

Merged
merged 3 commits into from Jan 6, 2022
Merged

boards: cpu: replace GPIO_UNDEF by SPI_CS_UNDEF in SPI configuration #17468

merged 3 commits into from Jan 6, 2022

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jan 4, 2022 •
edited

Contribution description

STM32, Kinetis and cc2538 based boards are updated.

This PR make the SPI implementations and configurations of kinetis, stm32 and cc2538 cpu/boards valid API wise.

It's a takeover of #6486

Testing procedure

A green CI should be enough

Issues/PRs references

Takeover of #6486, so closes #6486

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 4, 2022
@github-actions github-actions bot added Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Jan 4, 2022
@aabadie aabadie requested a review from smlng as a code owner January 4, 2022 12:01
@aabadie aabadie force-pushed the pr/boards/stm32_spi_cs_undef branch from 91fce3b to 58171bb Compare January 4, 2022 15:02
gschorcht
gschorcht reviewed Jan 6, 2022
View reviewed changes
cpu/kinetis/periph/spi.c Outdated Show resolved Hide resolved
gschorcht
gschorcht reviewed Jan 6, 2022
View reviewed changes
cpu/stm32/periph/spi.c Outdated Show resolved Hide resolved
@aabadie aabadie force-pushed the pr/boards/stm32_spi_cs_undef branch from 58171bb to 3c0e405 Compare January 6, 2022 11:34
@aabadie
Copy link
Contributor Author

aabadie commented Jan 6, 2022

All comments addressed and directly squashed.

gschorcht
gschorcht approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small and straightforward cleanup.

@aabadie aabadie enabled auto-merge January 6, 2022 11:52
@aabadie aabadie merged commit ec43e2d into RIOT-OS:master Jan 6, 2022
@aabadie aabadie deleted the pr/boards/stm32_spi_cs_undef branch January 6, 2022 14:22
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschorcht gschorcht gschorcht approved these changes

@DipSwitch DipSwitch Awaiting requested review from DipSwitch

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aabadie @gschorcht @fjmolinas