Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: remove deprecation warnings raised with flasher tools old vars #17490

Merged
merged 3 commits into from Jan 13, 2022

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jan 8, 2022

Contribution description

Make variables used for flasher tools were refactored (mostly renamed with tools specific namespaces) beginning of 2021 and deprecation warnings were added at that moment.

This PR removes all the deprecation warnings and the support for the old variables names.

Testing procedure

  • Green CI

Issues/PRs references

Can't find the old PRs related

@aabadie aabadie added the Process: removal Integration Process: The PR is removing a deprecated feature or API label Jan 8, 2022
@github-actions github-actions bot added Area: build system Area: Build system Area: tools Area: Supplementary tools labels Jan 8, 2022
@aabadie aabadie changed the title make: remove deprecation warnings raised with old flasher tools vars make: remove deprecation warnings raised with flasher tools old vars Jan 8, 2022
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jan 8, 2022
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems nice, I always like removing old stuff! ACK!

@aabadie aabadie merged commit f22ba30 into RIOT-OS:master Jan 13, 2022
@aabadie aabadie deleted the pr/make/tools_remove_deprecated_vars branch January 13, 2022 16:01
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: removal Integration Process: The PR is removing a deprecated feature or API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants