New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys/net/sock_util: add sock_tl_name2ep() to optionally perform DNS lookups #17510
Conversation
Can we make this its own function that then calls |
(you also might not want to fallback to a name in some use case and explicitly want to call |
Mind you that The idea was that all users (e.g. |
I don't see how this is relevant... they are still the conversion functions from string to endpoint.
If you get something for free with unforeseen consequences, it is never really for free. IMHO we should change the usage of |
f1b92a0
to
a5dab6e
Compare
I added a new |
e4bd965
to
007c7b1
Compare
007c7b1
to
3f95f39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK (after that fix).
Fix applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contribution description
This adds a new helper function
sock_tl_name2ep()
that will perform a DNS lookup if thesock_dns
is used.Otherwise it behaves exactly as
sock_tl_str2ep()
Testing procedure
Tests were added to
tests/netutils
Issues/PRs references