Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

board/iot-lab_M3: clean up and GPIO definitions in periph_conf.h #1757

Closed
wants to merge 2 commits into from
Closed

board/iot-lab_M3: clean up and GPIO definitions in periph_conf.h #1757

wants to merge 2 commits into from

Conversation

thomaseichinger
Copy link
Member

No description provided.

@thomaseichinger thomaseichinger added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Oct 1, 2014
@thomaseichinger thomaseichinger added this to the Release NEXT MAJOR milestone Oct 1, 2014
@haukepetersen
Copy link
Contributor

I just had an idea for making this even nicer: as GPIO_x_PIN is always equal to GPIO_x_EXTI_LINE, why not change the cpu/stm32f1/gpio.c, so it uses GPIO_x_PIN instead directly.
-> see PR against your branch.

@thomaseichinger
Copy link
Member Author

I also added using GPIO_x_PIN usage into the ISRs. Sorry, squashed into your commit.

haukepetersen
haukepetersen reviewed Oct 2, 2014
View reviewed changes
cpu/stm32f1/periph/gpio.c
@@ -1023,7 +1023,7 @@ __attribute__((naked)) void isr_exti0(void)
ISR_ENTER();
if (EXTI->PR & EXTI_PR_PR0) {
EXTI->PR |= EXTI_PR_PR0; /* clear status bit by writing a 1 to it */
config[GPIO_0].cb(config[GPIO_0].arg);
config[GPIO_0_PIN].cb(config[GPIO_0_PIN].arg);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these look strange, I think the original version was correct?!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be config[GPIO_IRQ_0].cb(config[GPIO_IRQ_0].arg);

@thomaseichinger thomaseichinger added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Oct 2, 2014
@thomaseichinger
Copy link
Member Author

will get further additions

@thomaseichinger
Copy link
Member Author

Cleanup included in #1756.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@haukepetersen haukepetersen

Labels
Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ARM Platform: This PR/issue effects ARM-based platforms State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2014.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomaseichinger @haukepetersen