Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/stm32f1: guard isr_exti9_5 and isr_exti15_10 if no GPIO_IRQ is enabled #1763

Closed
wants to merge 1 commit into from

Conversation

dangnhat
Copy link
Member

@dangnhat dangnhat commented Oct 6, 2014

This PR adds guards around isr_exti9_5, isr_exti15_10 if there are no GPIO_IRQs for these handlers are enabled. Thus, these handlers can be free to use in user's code.

@dangnhat dangnhat added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Oct 6, 2014
@thomaseichinger
Copy link
Member

These additions are included in #1756. Usage changed to use #ifdef because of a possible mapping of GPIO_IRQ_x -> GPIO_0 -> 0 which wouldn't work using #if GPIO_IRQ_x.
Do you see your changes addressed in #1756? If yes, I think we could close this one, else let me know.

@dangnhat
Copy link
Member Author

dangnhat commented Oct 8, 2014

@thomaseichinger : yep 👍 , close this PR now.

@dangnhat dangnhat closed this Oct 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants