Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/fatfs: enable exFAT support #17798

Merged
merged 1 commit into from Mar 11, 2022
Merged

pkg/fatfs: enable exFAT support #17798

merged 1 commit into from Mar 11, 2022

Conversation

benpicco
Copy link
Contributor

Contribution description

Enabling exFAT requires enabling long file names, so enable LFN if exFAT is enabled.
exFAT (and LFN) also requires bumping the per-file/per-dir buffer.

Testing procedure

Can be tested with

CFLAGS += -DFATFS_FFCONF_OPT_FS_EXFAT=1

2022-03-11 13:25:24,438 - INFO # > ls /
2022-03-11 13:25:24,438 - INFO # 
2022-03-11 13:25:24,441 - INFO # System Volume Information
2022-03-11 13:25:24,441 - INFO # test
2022-03-11 13:25:24,443 - INFO # hello.txt	19 B
2022-03-11 13:25:24,444 - INFO # total 1 files
2022-03-11 13:25:28,907 - INFO # > vfs r /hello.txt 32
2022-03-11 13:25:28,908 - INFO # 
2022-03-11 13:25:28,915 - INFO # 00000000: 4865 6c6c 6f20 6672 6f6d 2057 696e 646f  Hello from Windo
2022-03-11 13:25:28,920 - INFO # 00000010: 7773 21                                  ws!
2022-03-11 13:25:28,921 - INFO # -- EOF --

Issues/PRs references

@benpicco
pkg/fatfs: enable exFAT support
805bfc7 
Enabling exFAT requires enabling long file names, so enable LFN if
exFAT is enabled.
exFAT (and LFN) also requires bumping the per-file/per-dir buffer.

Can be tested with

    CFLAGS += -DFATFS_FFCONF_OPT_FS_EXFAT=1
@github-actions github-actions bot added Area: pkg Area: External package ports Area: sys Area: System labels Mar 11, 2022
maribu
maribu approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Code changes look sane and test output was provided.

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 11, 2022
@benpicco benpicco enabled auto-merge March 11, 2022 20:34
@benpicco benpicco merged commit 9f73630 into RIOT-OS:master Mar 11, 2022
@benpicco benpicco deleted the pkg/fatfs-exfat branch March 11, 2022 21:58
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@dylad dylad Awaiting requested review from dylad

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: pkg Area: External package ports Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benpicco @maribu @OlegHahm