Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/pbkdf2: enlarge stdio rx buffer #17928

Merged
merged 1 commit into from Apr 13, 2022
Merged

Conversation

kfessel
Copy link
Contributor

@kfessel kfessel commented Apr 13, 2022

Contribution description

The pbkdf2-test contains transfers of upto 67 byte (65+2) 87 byte (64*8/6+1) (8/6 is BASE64) only limited by the speed of the serial connection.
The default rx buffer is 64 bytes -> if uart irqs are tight enough the bytes are not taken fast enough from the buffer and some are lost -> test fails

the failing test can be seen by sometimes failing on the emulated microbit in murdock.

The large writes are defined by pbkdf2/tests/02-random.py

This enlarges the buffer to 2^7 (128) bytes

Testing procedure

read and exec that test; sadly one might have to do multiple execs of that test to see it fail without this PR

Issues/PRs references

split out from #17918 as it is not that related to murdock

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Apr 13, 2022
@kfessel kfessel added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 13, 2022
@kfessel kfessel requested a review from benpicco April 13, 2022 11:37
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Murdock likes it and I really like not getting unrelated failures in the CI run anymore :)

@maribu maribu enabled auto-merge April 13, 2022 13:36
@maribu maribu merged commit a091fa8 into RIOT-OS:master Apr 13, 2022
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants