cpu/sam0_common: adc: Automatically configure external reference pin #18042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: cpu
dylad
reviewed
May 12, 2022
Comment on lines
+226
to
+235
| #ifdef ADC_REFCTRL_REFSEL_AREFA | ||
| if (ADC_REF_DEFAULT == ADC_REFCTRL_REFSEL_AREFA) { | ||
| gpio_init_mux(ADC_REFSEL_AREFA_PIN, GPIO_MUX_B); | ||
| } | ||
| #endif | ||
| #ifdef ADC_REFCTRL_REFSEL_AREFB | ||
| if (ADC_REF_DEFAULT == ADC_REFCTRL_REFSEL_AREFB) { | ||
| gpio_init_mux(ADC_REFSEL_AREFB_PIN, GPIO_MUX_B); | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Jut wondering: Why did you use #ifdef for these two ? Looks like they are always present.
There was a problem hiding this comment.
Just for consistency
dylad
added
the
CI: ready for build
benpicco
added
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The ADC can be configured to use an input pin for the external reference voltage.
Automatically configure this pin when
ADC_REF_DEFAULTis set accordingly.On all members of the family PA03 and P04 can be used as reference A and B respectively. SAM D5x/E5x also allows to use PA06 as reference C.
Testing procedure
Set
ADC_REFSEL_AREFB_PINto e.g.ADC_REFCTRL_REFSEL_AREFAand connect a reference voltage to PA03, then runtests/periph_adc.Issues/PRs references