gcoap: add helper function to get request header from a request memo #18095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
the
Type: cleanup
miri64
requested review from
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
github-actions
bot
added
Area: CoAP
cgundogan
reviewed
May 12, 2022
cgundogan
approved these changes
May 12, 2022
cgundogan
added
Reviewed: 1-fundamentals
miri64
force-pushed
the
gcoap/enh/get-req-hdr-from-memo
branch
from
a733843
to
584681f
Compare
cgundogan
reviewed
May 12, 2022
| * @return The request header for the given request memo. | ||
| */ | ||
| static inline coap_hdr_t *gcoap_request_memo_get_hdr(const gcoap_request_memo_t *memo) | ||
| { |
There was a problem hiding this comment.
Not critical: what's your opinion on adding an assert(memo != NULL)?
There was a problem hiding this comment.
Would require to include assert.h and also, since the macro uses RIOT_FILE_RELATIVE the provided line would be wrong (it would point to the including C-file). That's why I intentially omitted it.
There was a problem hiding this comment.
On the premise that the compiler really inlines this inline function ..
There was a problem hiding this comment.
I think it will still take the line and file from code.
There was a problem hiding this comment.
But RIOT_FILE_RELATIVE is broken wtr, not the compiler ;-).
miri64
force-pushed
the
gcoap/enh/get-req-hdr-from-memo
branch
from
584681f
to
e9a12b7
Compare
|
Rebased, after #17801 got merged. |
miri64
added
the
CI: ready for build
miri64
force-pushed
the
gcoap/enh/get-req-hdr-from-memo
branch
from
e9a12b7
to
cbbde07
Compare
|
Found another occurance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Just some code-deduplication.
Testing procedure
examples/gcoapshould still compile with and without thegcoap_forward_proxy.Issues/PRs references
Spotted by @cgundogan in #17801 but can be merged independent of it (but might cause merge conflicts there or here).