Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/esp32: cleanup board_init_common #18238

Merged
merged 1 commit into from Jun 22, 2022
Merged

boards/esp32: cleanup board_init_common #18238

merged 1 commit into from Jun 22, 2022

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR removes board_init_common for ESP32 as it is no longer needed.

Testing procedure

Since board_init_common was empty, green CI should be sufficient.

Issues/PRs references

Split off from PR #17841

@gschorcht
boards/esp32: cleanup board_init_common
d00c6b0 
board_init_common isn't needed any longer.
@github-actions github-actions bot added the Area: boards Area: Board ports label Jun 21, 2022
@gschorcht gschorcht added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jun 21, 2022
@gschorcht gschorcht requested a review from benpicco June 21, 2022 14:26
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 22, 2022
@maribu maribu enabled auto-merge June 22, 2022 06:24
@maribu maribu merged commit 95df0e8 into RIOT-OS:master Jun 22, 2022
@gschorcht gschorcht deleted the boards/esp32/cleanup_board_init_common branch June 25, 2022 22:57
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gschorcht @benpicco @chrysn @maribu