rust: Explicitly select nightly #18243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples have previously relied on the (really: some) nightly toolchain to be the default. As that, in practice, is a problematic assumption, the latest toolchain to use is now determined programmatically, and that is set explicitly on the examples that use nightly. Workaround-For: rust-lang/rustup#3015
github-actions
bot
added
Area: build system
chrysn
added
CI: ready for build
chrysn
added
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples have previously relied on the (really: some) nightly toolchain
to be the default. As that, in practice, is a problematic assumption,
the latest toolchain to use is now determined programmatically, and that
is set explicitly on the examples that use nightly.
Workaround-For: rust-lang/rustup#3015
This is somewhat related to #18220 -- but they should complement each other transparently enough that merging them in any order should do the right thing.
Testing
rustup default nightlyorrustup default stable, or set arustup override, and the examples should still all build, with and without BUILD_IN_DOCKER=1.(Even a rust-toolchain.yaml file should be ignored in the examples -- if CARGO_CHANNEL is set empty, that would be used, but testing that is excessive at this stage)