Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/tinydtls: bump version #18368

Merged
merged 1 commit into from Jul 26, 2022
Merged

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Jul 25, 2022

Contribution description

All our patches got merged, so we can drop them.
I did not find an upstream commit/PR for 0006-crypto-only-one-HMAC-context-is-required.patch, but it also no longer applies, so I dropped it. This patch was applied upstream too, it was just squashed - #17878 (comment)

Testing procedure

examples/gcoap_dtls still works

> coap get fe80::7837:fcff:fe7d:1aaf 5684 /.well-known/core
gcoap_cli: sending msg ID 28796, 23 bytes
gcoap: response Success, code 2.05, 46 bytes
</cli/stats>;ct=0;rt="count";obs,</riot/board>

Wireshark

Issues/PRs references

@benpicco benpicco requested a review from miri64 July 25, 2022 20:17
@github-actions github-actions bot added the Area: pkg Area: External package ports label Jul 25, 2022
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 25, 2022
@miri64
Copy link
Member

miri64 commented Jul 26, 2022

examples/gcoap_dtls still works

Confirmed. examples/dtls-echo runs into this assertion on native and iotlab-m3 at the client side: https://github.com/eclipse/tinydtls/blob/bda40789a7c280f248eeca6d09ddd624cdaf5dc8/session.c#L146 However, this is also the case on master, so that needs to be bisected (and is not a problem of this PR).

examples/dtls-sock and tests/pkg_tinydtls_sock_async work as expected.

@miri64 miri64 merged commit 9e283b9 into RIOT-OS:master Jul 26, 2022
@benpicco benpicco deleted the pkg/tinydtls-bump branch July 26, 2022 13:06
@miri64
Copy link
Member

miri64 commented Jul 26, 2022

Confirmed. examples/dtls-echo runs into this assertion on native and iotlab-m3 at the client side: https://github.com/eclipse/tinydtls/blob/bda40789a7c280f248eeca6d09ddd624cdaf5dc8/session.c#L146 However, this is also the case on master, so that needs to be bisected (and is not a problem of this PR).

Bisected using the following script (test_dtls.py deployed in RIOTBASE):

#! /usr/bin/env python3
import sys

from riotctrl.ctrl import RIOTCtrl

sys.path.append("dist/pythonlibs")
from riotctrl_shell.netif import IfconfigListParser, Ifconfig

if __name__ == "__main__":
    RIOTCtrl.MAKE_ARGS = ("-j",)
    ctrl0 = RIOTCtrl(application_directory="examples/dtls-echo", env={"WERROR": "0"})
    ctrl1 = RIOTCtrl(
        application_directory="examples/dtls-echo", env={"PORT": "tap1", "WERROR": "0"}
    )
    ctrl0.make_run(["distclean", "flash"])
    with ctrl0.run_term(reset=False), ctrl1.run_term(reset=False):
        ctrl0.term.logfile = sys.stdout
        ctrl1.term.logfile = sys.stdout
        shell0 = Ifconfig(ctrl0)
        shell1 = Ifconfig(ctrl1)
        netifs = IfconfigListParser().parse(shell1.ifconfig_list())
        server_addr = list(netifs.values())[0]["ipv6_addrs"][0]["addr"]
        res = shell1.cmd("dtlss start")
        assert res.strip() == "dtlss start"
        res = shell0.cmd(f"dtlsc {server_addr} hello")
        assert "Client: got DTLS Data App -- hello --" in res
git bisect good 9a2ccd51f45d78613432c724dbf3c
git bisect bad master
git bisect run python3 test_dtls.py

This found d424aae to introduce the regression. Seems like the functionality was not tested in #17765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants