Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/pkg_lvgl_touch: randomize button position on click #18481

Merged
merged 1 commit into from Aug 27, 2022
Merged

tests/pkg_lvgl_touch: randomize button position on click #18481

merged 1 commit into from Aug 27, 2022

Conversation

benpicco
Copy link
Contributor

Contribution description

The test is a bit boring. To spice it up, randomize the button position to show the user it worked without having to attach a serial console.

Testing procedure

Issues/PRs references

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Aug 20, 2022
@aabadie
Copy link
Contributor

aabadie commented Aug 24, 2022

Nice improvement, thanks!
I don't have the hardware to test this for the moment but will do next week. Otherwise the changes look good.

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Aug 24, 2022
@benpicco
Copy link
Contributor Author

No need for hardware, just install libsdl2-dev:i386

image

aabadie
aabadie approved these changes Aug 27, 2022
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, there's no need for hardware and I confirm that this works like a charm on native.

ACK

@aabadie aabadie enabled auto-merge August 27, 2022 14:19
@aabadie aabadie merged commit feb98ce into RIOT-OS:master Aug 27, 2022
@benpicco benpicco deleted the tests/pkg_lvgl_touch-random branch August 28, 2022 08:53
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benpicco @aabadie @maribu