Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefiles: Rust fixes and info extensions #18630

Merged
merged 4 commits into from Sep 23, 2022

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Sep 23, 2022

Contribution description

Getting information on which precise Rust version is used can be hard, because it is influenced by variables set in the build process, which were previously not accessible.

This is

  • adding make info-rust,
  • adding Rust-related variables on make info-build,
  • fixes CFLAGS output in info-build, and
  • removes duplication in the Rust build files.

Testing procedure

  • Green CI says that the Rust build duplication was actually duplication.
  • Look at the output of make info-build and make info-rust.
  • In particular, make -C examples/rust-gcoap info-build, and look at how CFLAGS crashed before and now doesn't.

Issues/PRs references

It'd be great to get this in fast to use it in finding out why RIOT-OS/rust-riot-wrappers#14 fails.

Asking @maribu for a review because if one of the things I'm just debugging hits #18619 (unlikely, but can't rule it out fast either), this would speed things up there.

As for why the `-e` is being removed, observe that the `-e` would
otherwise be printed; there is an [elaborate treatise] on what happens
there.

[elaborate treatise]: https://unix.stackexchange.com/questions/700675/why-is-echo-e-behaving-weird-in-a-makefile
Back in 36a029c, rather than being line wrapped, this was duplicated.
@chrysn chrysn added Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: Rust Area: Rust wrapper labels Sep 23, 2022
@chrysn chrysn requested a review from maribu September 23, 2022 00:13
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 merged commit 2e23885 into RIOT-OS:master Sep 23, 2022
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
@chrysn chrysn deleted the info-rust branch February 25, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: Rust Area: Rust wrapper CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants