sys/checksum: add CRC-16 implementation without lookup table #18701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
requested review from
leandrolanzieri,
jia200x,
MrKevinWeiss and
jue89
as code owners
github-actions
bot
added
Area: build system
maribu
approved these changes
Oct 6, 2022
Ah, perfect! :) |
benpicco
added
the
CI: ready for build
Murdock results✔️ PASSED 98e18ed drivers/dose: make use of checksum module
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The look-up table for CRC-16 can be quite heavy, so also provide an implementation without it.
The look-up table can be enabled with the
crc16_fastpseudo-module.Since this removes @jue89's concern with the common implementation, also use it in DOSE instead of re-implementing CRC-16 there. (DOSE's CRC-16 implementation is now the common one without the look-up table).
Testing procedure
The
tests-checksumunittest still works with and withoutcrc16_fast.Issues/PRs references