Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-on-iotlab: several fixes to make it runnable again #18722

Merged
merged 2 commits into from
Oct 17, 2022
Merged

test-on-iotlab: several fixes to make it runnable again #18722

merged 2 commits into from
Oct 17, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 10, 2022

Contribution description

Adds a few fixes, so that some of the tests currently failing in the test-on-iotlab action run again.

Testing procedure

I will start a manual run of the action.

Issues/PRs references

None

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Oct 10, 2022
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 10, 2022
@github-actions github-actions bot added Area: CI Area: Continuous Integration of RIOT components Area: tests Area: tests and testing framework labels Oct 10, 2022
@miri64
Copy link
Member Author

miri64 commented Oct 10, 2022

Running tests on Murdock as well, since I am curious, if my change to tests/gnrc_rpl will also be valid for it.

@riot-ci
Copy link

riot-ci commented Oct 10, 2022 •
edited
Loading

Murdock results

✔️ PASSED

509d251 test-on-iotlab: add missing scapy dependency

Success Failures Total Runtime
2346 0 2346 01h:22m:47s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

aabadie
aabadie reviewed Oct 10, 2022
View reviewed changes
tests/gnrc_rpl/Makefile
Comment on lines 12 to 21
ifeq (native, $(BOARD))
USEMODULE += socket_zep
USEMODULE += socket_zep_hello
USEMODULE += netdev
TERMFLAGS += -z 127.0.0.1:17754 # Murdock has no IPv6 support
else
USEMODULE += netdev_default
# automated test only works on native
TESTS=
endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit out of scope but I'm wondering if that shouldn't go in a Makefile.board.dep and if maybe it could also fix the initial issue ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, yes. But there are other tests (e.g. tests/lwip) that do this, so definitely out of scope, IMHO. Should I just move the TESTS assignment there for now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it this way

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which way now? 😅 The way I do it here already or putting it into Makefile.board.dep?

@miri64 miri64 added CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 10, 2022
This was referenced Oct 12, 2022
Merged
Closed
@maribu maribu enabled auto-merge October 17, 2022 07:22
@maribu maribu merged commit fb318c0 into RIOT-OS:master Oct 17, 2022
@miri64 miri64 deleted the test-on-iotlab/fix/several branch October 17, 2022 08:09
@miri64
Copy link
Member Author

miri64 commented Oct 17, 2022

Is a backport needed?

@maribu
Copy link
Member

maribu commented Oct 17, 2022

Yes, please :)

@maribu maribu added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Oct 17, 2022
@miri64 miri64 mentioned this pull request Oct 17, 2022
Merged
@miri64
Copy link
Member Author

miri64 commented Oct 17, 2022

Backport provided in #18757

@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie left review comments

@maribu maribu maribu approved these changes

@benpicco benpicco Awaiting requested review from benpicco

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components Area: tests Area: tests and testing framework CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miri64 @riot-ci @maribu @aabadie @kaspar030