Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nanocoap_sock: implement nanocoap_sock_delete() #18738

Merged
merged 2 commits into from Jan 10, 2023
Merged

nanocoap_sock: implement nanocoap_sock_delete() #18738

merged 2 commits into from Jan 10, 2023

Conversation

benpicco
Copy link
Contributor

Contribution description

We support GET, PUT and POST, so also implement DELETE.

Testing procedure

This can be tested with examples/gcoap_fileserver:

main(): This is RIOT! (Version: 2022.10-devel-1142-gbec06-nanocoap_sock_delete)
nanocoap test app
All up, running the shell now

> url delete coap://[fe80::58b0:8ff:fe67:ad82]/vfs/core
nanocoap: send 13 bytes (5 tries left)
nanocoap: waiting for response (timeout: 2125925 µs)
nanocoap: response code=202

> url delete coap://[fe80::58b0:8ff:fe67:ad82]/vfs/core
nanocoap: send 13 bytes (5 tries left)
nanocoap: waiting for response (timeout: 2772702 µs)
nanocoap: response code=404
res: Unknown error -6

Issues/PRs references

@github-actions github-actions bot added Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework labels Oct 13, 2022
@benpicco benpicco requested a review from maribu October 15, 2022 21:38
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 15, 2022
@riot-ci
Copy link

riot-ci commented Oct 15, 2022

Murdock results

✔️ PASSED

794fa43 tests/nanocoap_cli: add DELETE to test

Success Failures Total Runtime
1981 0 1983 06m:23s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@benpicco benpicco added this to Backlog / Proposals in RIOT Sprint Day via automation Oct 17, 2022
@benpicco benpicco added this to In progress in COAP via automation Oct 17, 2022
@benpicco benpicco requested a review from miri64 October 25, 2022 17:37
maribu
maribu approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

RIOT Sprint Day automation moved this from Backlog / Proposals to Waiting For Murdock Jan 10, 2023
@bors
Copy link
Contributor

bors bot commented Jan 10, 2023

Build succeeded:

@bors bors bot merged commit 53176f7 into RIOT-OS:master Jan 10, 2023
RIOT Sprint Day automation moved this from Waiting For Murdock to Done Jan 10, 2023
COAP automation moved this from In progress to Done Jan 10, 2023
@benpicco benpicco deleted the nanocoap_sock_delete branch January 10, 2023 15:25
@jia200x jia200x added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@chrysn chrysn Awaiting requested review from chrysn

@fabian18 fabian18 Awaiting requested review from fabian18

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@kfessel kfessel Awaiting requested review from kfessel

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
COAP
Done
RIOT Sprint Day
  
Done
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benpicco @riot-ci @maribu @jia200x