Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/at86rf2xx: migrate to ztimer #18822

Merged
merged 3 commits into from Oct 31, 2022
Merged

drivers/at86rf2xx: migrate to ztimer #18822

merged 3 commits into from Oct 31, 2022

Conversation

jue89
Copy link
Contributor

@jue89 jue89 commented Oct 29, 2022

Contribution description

Migrate the AT86RF2xx driver to ztimer.

Testing procedure

Green murdock.

The ztimer_xtimer_compat module is already doing the same thing:

xtimer_compat.h 
static inline void xtimer_usleep(uint32_t microseconds)
{
    ztimer_sleep(ZTIMER_USEC, microseconds);
}

Issues/PRs references

@jue89 jue89 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 29, 2022
@github-actions github-actions bot added the Area: Kconfig Area: Kconfig integration label Oct 29, 2022
@riot-ci
Copy link

riot-ci commented Oct 29, 2022 •
edited

Murdock results

✔️ PASSED

782409e tests/driver_at86rf2xx_aes: remove unnessesary xtimer.h import

Success Failures Total Runtime
2000 0 2000 06m:53s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Oct 29, 2022
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Oct 29, 2022
@MrKevinWeiss
Copy link
Contributor

x-timer is not officially deprecated, though everyone I talked to says it should be... I started but I guess we cannot really deprecate until everything in RIOT isn't using it anymore. #18560 BTW.

This is one of the needed steps in the process, so thanks for pushing it!

@miri64
Copy link
Member

miri64 commented Oct 31, 2022

I started but I guess we cannot really deprecate until everything in RIOT isn't using it anymore. #18560 BTW.

We can deprecate it, but we then need to make sure that until the removal date, the full migration is done :-).

@maribu maribu merged commit d704a1a into RIOT-OS:master Oct 31, 2022
@jue89
Copy link
Contributor Author

jue89 commented Oct 31, 2022

Thank you!

@jue89 jue89 deleted the feature/at86rf2xx_ztimer branch October 31, 2022 19:07
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@daniel-k daniel-k Awaiting requested review from daniel-k daniel-k is a code owner

@smlng smlng Awaiting requested review from smlng

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jue89 @riot-ci @MrKevinWeiss @miri64 @maribu @kaspar030