makefiles: Use grep -q rather than --quiet
#18904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrysn
added
Area: build system
Murdock results✔️ PASSED 269b33f makefiles: Use
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
maribu
approved these changes
Nov 14, 2022
`--quiet` is a GNUism; Alpine's busybox grep only supports the minimal -q option required by POSIX.
chrysn
force-pushed
the
posixly-correct-grep
branch
from
66ba876
to
269b33f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--quietis a GNUism; Alpine's busybox grep only supports the minimal-qoption required by POSIX.Testing procedure
This allows using Rust on RIOT on an Alpine build system to fail one step later (but as for the correctness of the PR, this shoudl be evident by reading the file).