Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp8266/bootloader: remove compile time from banner #19097

Merged
merged 1 commit into from
Jan 5, 2023
Merged

cpu/esp8266/bootloader: remove compile time from banner #19097

merged 1 commit into from
Jan 5, 2023

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Jan 5, 2023 •
edited

Contribution description

This PR fixes the problem with the compilation of the nightlies.

The compilation of the bootloader has been added with PR #19074. The compile time has been removed from the banner in the bootloader to fix the problem of different hashes when compiling with and without TEST_KCONFIG.

Testing procedure

Green CI.

Issues/PRs references

@gschorcht
cpu/esp8266/bootloader: remove compile time from banner
2b4e652 
The compile time has been removed from the banner to fix the problem of different hashes when compiling with and without `TEST_KONFIG`.
@github-actions github-actions bot added the Area: pkg Area: External package ports label Jan 5, 2023
@gschorcht gschorcht added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 5, 2023
@riot-ci
Copy link

riot-ci commented Jan 5, 2023

Murdock results

✔️ PASSED

2b4e652 cpu/esp8266/bootloader: remove compile time from banner

Success Failures Total Runtime
6768 0 6770 13m:48s

Artifacts

kaspar030
kaspar030 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030
Copy link
Contributor

bors merge

@MrKevinWeiss
Copy link
Contributor

Ahhh, so it was a timestamp in the bootloader! Thanks for sorting it out @gschorcht

@bors
Copy link
Contributor

bors bot commented Jan 5, 2023

Build succeeded:

@bors bors bot merged commit b9fa39a into RIOT-OS:master Jan 5, 2023
@gschorcht
Copy link
Contributor Author

Thanks

@gschorcht gschorcht deleted the cpu/esp8266/fix_bootloader_hash_problem branch January 6, 2023 05:17
@MrKevinWeiss
Copy link
Contributor

So this is the one that make esp fail in nightlies...

I did a binary diff (sorry for the screenshot)

image

That is the only difference. It seems to be introduce whenever a patch is added (regardless of code or not as I tested with just a newline in the README and it still failed).

I ran:

python3 dist/tools/compile_test/compile_like_murdock.py -a tests/shell -b esp8266-esp-12x -j 7

@MrKevinWeiss
Copy link
Contributor

could it be that there is a hash of the bootloader state included in somewhere here

@gschorcht
Copy link
Contributor Author

This is really strange. Where can I find the results?

python3 dist/tools/compile_test/compile_like_murdock.py -a tests/shell -b esp8266-esp-12x -j 7

@gschorcht
Copy link
Contributor Author

could it be that there is a hash of the bootloader state included in somewhere here

Hm, the difference seems to be the any kind of commit hash. The ESP8266-RTOS-SDK doesn't know these hashes. I can't imagine that the bootloader compilation writes something in the binary but I will check.

@gschorcht
Copy link
Contributor Author

The problem was caused in pkg/esp8266_sdk/Makefile which generates build/pkg/esp8266_sdk/build-libs/esp8266_idf_version.h. PR #19123 hopefully fixes the problem.

@gschorcht
Copy link
Contributor Author

@MrKevinWeiss Thanks for figuring out that problem. It helped a lot to find the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gschorcht @riot-ci @kaspar030 @MrKevinWeiss