boards/gd32v: improve board definitions #19249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
requested review from
leandrolanzieri,
jia200x and
MrKevinWeiss
as code owners
github-actions
bot
added
Area: boards
gschorcht
force-pushed
the
boards/gd32v/improve_board_definitions
branch
from
6a4828e
to
b46ffdb
Compare
gschorcht
added
Type: enhancement
The default I2C device configuration allows to define up to two I2C devices `I2C_DEV(0)` and `I2C_DEV(1)`. `I2C_DEV(0)` is always defined if the I2C peripheral is enabled by the module `periph_spi`. The second I2C device `I2C_DEV(1)` is only defined if `I2C_DEV_1_USED` is defined by the board. This allows to use the default configuration with one or two I2C devices depending on whether other peripherals are enabled that would collide with the I2C devices.
The default SPI device configuration allows to define up to two SPI devices `SPI_DEV(0)` and `SPI_DEV(1)`. `SPI_DEV(0)` is always defined if the SPI peripheral is enabled by the module `periph_spi`. The second SPI device `SPI_DEV(1)` is only defined if `SPI_DEV_1_USED` is defined by the board. This allows to use the default configuration with one or two SPI devices depending on whether other peripherals are enabled that would collide with the SPI devices. Furthermore, the CS signal in the SPI configuration is given by a define that can be overriden with another pin if the default CS signal is connected to an unused hardware.
The ADC configuration was too complex. It was hard to follow when certain ADC lines are available. Furthermore, the order of ADC lines did depend on the use of other peripherals. Now, either the TFT display is not connected and all ADC lines are available or the TFT display is connected and the second SPI device is used so that only the first 4 ADC lines are available.
Board-specific configuration not shown any longer directly in the top level menu but within a submenu.
Available peripherals for the board are now shown ordered by RIOT peripheral names and by pins.
Available peripherals for the board are now shown ordered by RIOT peripheral names and by pins.
gschorcht
force-pushed
the
boards/gd32v/improve_board_definitions
branch
from
b46ffdb
to
e24abe4
Compare
github-actions
bot
removed
the
Platform: RISC-V
benpicco
reviewed
Feb 6, 2023
| @@ -35,6 +35,8 @@ | |||
| #define CONFIG_CLOCK_HXTAL MHZ(8) /**< HXTAL frequency */ | |||
| #endif | |||
|
|
|||
| #define SPI_DEV_1_USED /**< Enable SPI_DEV(1) for the connected flash */ | |||
There was a problem hiding this comment.
When I hear connected SPI flash I see an opportunity to add an MTD device :D
There was a problem hiding this comment.
Of course, but we don't have a driver for SPI flash like the W25Q64 yet with the exception of ESP32.
There was a problem hiding this comment.
is it not just a standard SPI-NOR flash that's supported by mtd_spi_nor?
There was a problem hiding this comment.
Ah ok, mtd_spi_nor is already doing that job. I will try.
There was a problem hiding this comment.
When I hear connected SPI flash I see an opportunity to add an MTD device :D
Too bad, this is the Seeedstudio GD32 RISC-V board, which I don't have and can't order anywhere at the moment. So I can't try it out.
benpicco
approved these changes
Feb 6, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Feb 6, 2023
19249: boards/gd32v: improve board definitions r=benpicco a=gschorcht ### Contribution description This PR provides some small improvements of the existing board definitions for GD32VF103 boards for more flexibel default configurations and documentation of the board peripherals: - Allow the remapping of SPI0 pins in SPI configuration (ae984b0) - More flexible I2C configuration (0c33758) The default I2C device configuration allows to define up to two I2C devices `I2C_DEV(0)` and `I2C_DEV(1)`. `I2C_DEV(0)` is always defined if the I2C peripheral is enabled by the module `periph_spi`. The second I2C device `I2C_DEV(1)` is only defined if `I2C_DEV_1_USED` is defined by the board. This allows to use the default configuration with one or two I2C devices depending on whether other peripherals are enabled that would collide with the I2C devices. - More flexible SPI configuration (edbf59e) The default SPI device configuration allows to define up to two SPI devices `SPI_DEV(0)` and `SPI_DEV(1)`. `SPI_DEV(0)` is always defined if the SPI peripheral is enabled by the module `periph_spi`. The second SPI device `SPI_DEV(1)` is only defined if `SPI_DEV_1_USED` is defined by the board. This allows to use the default configuration with one or two SPI devices depending on whether other peripherals are enabled that would collide with the SPI devices. Furthermore, the CS signal in the SPI configuration is given by a define that can be overriden with another pin if the default CS signal is connected to an unused hardware. - Improve ADC config for Sipeed-Longan-Nano (c9c587e) The ADC configuration was too complex. It was hard to follow when certain ADC lines are available. Furthermore, the order of ADC lines did depend on the use of other peripherals. Now, either the TFT display is not connected and all ADC lines are available or the TFT display is connected and the second SPI device is used so that only the first 4 ADC lines are available. - Improve Kconfig for Sipeed-Longan-Nano (025f4fd) Board-specific configuration not shown any longer directly in the top level menu but within a submenu. - Improve peripherals documentation (7f0d560, e24abe4) Available peripherals for the board are now documented in two tables ordered by RIOT peripheral names and by pins. Although the different changes are small and mostly related to the documentation, I could split the PR if necessary. ### Testing Green CI ### Issues/PRs references Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
bors bot
added a commit
that referenced
this pull request
Feb 6, 2023
19249: boards/gd32v: improve board definitions r=benpicco a=gschorcht ### Contribution description This PR provides some small improvements of the existing board definitions for GD32VF103 boards for more flexibel default configurations and documentation of the board peripherals: - Allow the remapping of SPI0 pins in SPI configuration (ae984b0) - More flexible I2C configuration (0c33758) The default I2C device configuration allows to define up to two I2C devices `I2C_DEV(0)` and `I2C_DEV(1)`. `I2C_DEV(0)` is always defined if the I2C peripheral is enabled by the module `periph_spi`. The second I2C device `I2C_DEV(1)` is only defined if `I2C_DEV_1_USED` is defined by the board. This allows to use the default configuration with one or two I2C devices depending on whether other peripherals are enabled that would collide with the I2C devices. - More flexible SPI configuration (edbf59e) The default SPI device configuration allows to define up to two SPI devices `SPI_DEV(0)` and `SPI_DEV(1)`. `SPI_DEV(0)` is always defined if the SPI peripheral is enabled by the module `periph_spi`. The second SPI device `SPI_DEV(1)` is only defined if `SPI_DEV_1_USED` is defined by the board. This allows to use the default configuration with one or two SPI devices depending on whether other peripherals are enabled that would collide with the SPI devices. Furthermore, the CS signal in the SPI configuration is given by a define that can be overriden with another pin if the default CS signal is connected to an unused hardware. - Improve ADC config for Sipeed-Longan-Nano (c9c587e) The ADC configuration was too complex. It was hard to follow when certain ADC lines are available. Furthermore, the order of ADC lines did depend on the use of other peripherals. Now, either the TFT display is not connected and all ADC lines are available or the TFT display is connected and the second SPI device is used so that only the first 4 ADC lines are available. - Improve Kconfig for Sipeed-Longan-Nano (025f4fd) Board-specific configuration not shown any longer directly in the top level menu but within a submenu. - Improve peripherals documentation (7f0d560, e24abe4) Available peripherals for the board are now documented in two tables ordered by RIOT peripheral names and by pins. Although the different changes are small and mostly related to the documentation, I could split the PR if necessary. ### Testing Green CI ### Issues/PRs references Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
|
bors retry |
|
Build succeeded: |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR provides some small improvements of the existing board definitions for GD32VF103 boards for more flexibel default configurations and documentation of the board peripherals:
The default I2C device configuration allows to define up to two I2C devices
I2C_DEV(0)andI2C_DEV(1).I2C_DEV(0)is always defined if the I2C peripheral is enabled by the moduleperiph_spi. The second I2C deviceI2C_DEV(1)is only defined ifI2C_DEV_1_USEDis defined by the board. This allows to use the default configuration with one or two I2C devices depending on whether other peripherals are enabled that would collide with the I2C devices.The default SPI device configuration allows to define up to two SPI devices
SPI_DEV(0)andSPI_DEV(1).SPI_DEV(0)is always defined if the SPI peripheral is enabled by the moduleperiph_spi. The second SPI deviceSPI_DEV(1)is only defined ifSPI_DEV_1_USEDis defined by the board. This allows to use the default configuration with one or two SPI devices depending on whether other peripherals are enabled that would collide with the SPI devices.Furthermore, the CS signal in the SPI configuration is given by a define that can be overriden with another pin if
the default CS signal is connected to an unused hardware.
The ADC configuration was too complex. It was hard to follow when certain ADC lines are available. Furthermore, the order of ADC lines did depend on the use of other peripherals. Now, either the TFT display is not connected and all ADC lines are available or the TFT display is connected and the second SPI device is used so that only the first 4 ADC lines are available.
Board-specific configuration not shown any longer directly in the top level menu but within a submenu.
Available peripherals for the board are now documented in two tables ordered by RIOT peripheral names and by pins.
Although the different changes are small and mostly related to the documentation, I could split the PR if necessary.
Testing
Green CI
Issues/PRs references