Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/mrf24j40: cleanup function #19635

Merged
merged 1 commit into from May 20, 2023
Merged

drivers/mrf24j40: cleanup function #19635

merged 1 commit into from May 20, 2023

Conversation

maribu
Copy link
Member

@maribu maribu commented May 20, 2023

Contribution description

_set_csma_params() spends some time to prepare a value in uint8_t tmp, which then is never used. Likely this is a leftover of moving code to mrf24j40_set_csma_max_retries(). This drops the leftover code.

Testing procedure

The driver should still correctly apply CSMA settings.

Issues/PRs references

Split out of #19634

@maribu
drivers/mrf24j40: cleanup function
c10b883 
`_set_csma_params()` spends some time to prepare a value in
`uint8_t tmp`, which then is never used. Likely this is a leftover
of moving code to `mrf24j40_set_csma_max_retries()`. This drops the
leftover code.
@maribu maribu added Area: network Area: Networking Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 20, 2023
@maribu maribu requested a review from jia200x May 20, 2023 15:00
@maribu maribu requested a review from bergzand as a code owner May 20, 2023 15:00
@github-actions github-actions bot removed the Area: network Area: Networking label May 20, 2023
@riot-ci
Copy link

riot-ci commented May 20, 2023

Murdock results

✔️ PASSED

c10b883 drivers/mrf24j40: cleanup function

Success Failures Total Runtime
6946 0 6946 10m:19s

Artifacts

aabadie
aabadie approved these changes May 20, 2023
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. ACK

@aabadie
Copy link
Contributor

aabadie commented May 20, 2023

bors merge

@maribu maribu mentioned this pull request May 20, 2023
Merged
4 tasks
@bors
Copy link
Contributor

bors bot commented May 20, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 8fc1187 into RIOT-OS:master May 20, 2023
30 checks passed
@maribu maribu deleted the drivers/mrf24j40 branch May 24, 2023 19:08
@maribu
Copy link
Member Author

maribu commented May 24, 2023

Thx :)

@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@jia200x jia200x Awaiting requested review from jia200x

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maribu @riot-ci @aabadie @benpicco