Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/openthread: model in kconfig #19671

Merged
merged 3 commits into from Jun 1, 2023
Merged

pkg/openthread: model in kconfig #19671

merged 3 commits into from Jun 1, 2023

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented May 26, 2023

Contribution description

As the title says. I just checked that the generated firmware size was the same with and without TEST_KCONFIG set to 1

Testing procedure

  • Green CI

Issues/PRs references

Tick one item in #16875

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 26, 2023
@github-actions github-actions bot added Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: pkg Area: External package ports labels May 26, 2023
@aabadie aabadie mentioned this pull request May 26, 2023
Closed
@riot-ci
Copy link

riot-ci commented May 26, 2023 •
edited

Murdock results

✔️ PASSED

77a11be drivers/kw41zrf: boards/openlabs-kw41z-mini: cleanup Kconfig

Success Failures Total Runtime
6933 0 6933 14m:20s

Artifacts

@aabadie aabadie added CI: no fast fail don't abort PR build after first error CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 26, 2023
@aabadie aabadie force-pushed the pr/pkg/openthread_kconfig branch from 4d11120 to e0c6300 Compare May 26, 2023 08:51
@MrKevinWeiss
Copy link
Contributor

There is also the /dist/tools/compile_test/compile_like_murdock.py -v -j 8 -a examples/openthread -b all which will compile and verify hashes for all boards for the new test (like in murdock nightly builds)... It may take some time though but can catch things like cflag value diffs not just module mismatches.

leandrolanzieri
leandrolanzieri reviewed May 30, 2023
View reviewed changes
pkg/openthread/Kconfig Outdated Show resolved Hide resolved
pkg/openthread/Kconfig Show resolved Hide resolved
pkg/openthread/Kconfig Outdated Show resolved Hide resolved
@aabadie
Copy link
Contributor Author

aabadie commented May 30, 2023

There is also the /dist/tools/compile_test/compile_like_murdock.py -v -j 8 -a examples/openthread -b all which will compile and verify hashes for all boards for the new test (like in murdock nightly builds)

Wasn't aware of that and it's incredibly useful to know!

@aabadie aabadie force-pushed the pr/pkg/openthread_kconfig branch from e0c6300 to 0b53898 Compare May 30, 2023 09:06
MrKevinWeiss
MrKevinWeiss reviewed Jun 1, 2023
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few fixups seem to be required:

diff --git a/boards/openlabs-kw41z-mini-256kib/Kconfig b/boards/openlabs-kw41z-mini-256kib/Kconfig
index 29f8a7b2cc..86e4283f16 100644
--- a/boards/openlabs-kw41z-mini-256kib/Kconfig
+++ b/boards/openlabs-kw41z-mini-256kib/Kconfig
@@ -21,5 +21,6 @@ config BOARD_OPENLABS_KW41Z_MINI_256KIB
     select HAS_PERIPH_UART
     select HAS_RIOTBOOT
 
+    select HAVE_KW41ZRF
     select HAVE_SAUL_ADC
     select HAVE_SAUL_GPIO
diff --git a/drivers/kw41zrf/Kconfig b/drivers/kw41zrf/Kconfig
index 31831f7182..56350a1f98 100644
--- a/drivers/kw41zrf/Kconfig
+++ b/drivers/kw41zrf/Kconfig
@@ -8,8 +8,7 @@
 config MODULE_KW41ZRF
     bool "KW41ZRF radio"
     depends on TEST_KCONFIG
-    depends on CPU_MODEL_MKW41Z256VHT4
-    depends on CPU_MODEL_MKW41Z512VHT4
+    depends on CPU_MODEL_MKW41Z256VHT4 || CPU_MODEL_MKW41Z512VHT4
     select MODULE_MCUX_XCVR_MKW41Z
     select MODULE_IEEE802154
     select MODULE_NETDEV

@MrKevinWeiss
Copy link
Contributor

Aside from that, if everything passes then I am happy.

@aabadie aabadie force-pushed the pr/pkg/openthread_kconfig branch from 0b53898 to 77a11be Compare June 1, 2023 10:20
@github-actions github-actions bot added Area: boards Area: Board ports Area: drivers Area: Device drivers labels Jun 1, 2023
MrKevinWeiss
MrKevinWeiss approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@MrKevinWeiss
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 1, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@aabadie
Copy link
Contributor Author

aabadie commented Jun 1, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 1, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 9d571c3 into RIOT-OS:master Jun 1, 2023
26 checks passed
@MrKevinWeiss
Copy link
Contributor

This broke master, I am working on a fix (after a meeting)

@aabadie aabadie deleted the pr/pkg/openthread_kconfig branch June 9, 2023 12:23
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri left review comments

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: drivers Area: Device drivers Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: pkg Area: External package ports CI: no fast fail don't abort PR build after first error CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aabadie @riot-ci @MrKevinWeiss @leandrolanzieri @benpicco