drivers/ft5x06: use a pointer to config parameters instead of copying them #19866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
added
Type: enhancement
benpicco
removed
the
State: waiting for other PR
|
This needs a rebase |
There is no need to copy the configuration parameter set to the device descriptor. A const pointer to the configuration parameter set in ROM is sufficient. It saves some 16 byte of RAM.
gschorcht
force-pushed
the
drivers/ft5x06_const_param_pointer
branch
from
f472f19
to
d88e46b
Compare
benpicco
approved these changes
Aug 23, 2023
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
Thanks for reviewing and merging 😄 |
bors bot
added a commit
that referenced
this pull request
Aug 27, 2023
19867: drivers/ft5x06: introduce conversion for X and Y coordinates r=aabadie a=gschorcht ### Contribution description This PR provides the parameter option to define how the X and Y coordinates have to be converted. To get coordinates from the touch panel that correspond to the display coordinates, it is often necessary to convert the coordinates from the touch pannel by swapping and mirroring them. For the sake of simplicity, possible rotations are additionally defined. The PR includes PRs #19860 and #19866 to be compilable. ### Testing procedure `tests/pkg/lvgl_touch` should still work for the `stm32f746g-disco` board. ``` BOARD=stm32f746g-disco make -C tests/pkg/lvgl_touch ``` ### Issues/PRs references ~Depends on PR #19860~ Depends on PR #19866 Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
There is no need to copy the configuration parameter set to the device descriptor. A const pointer to the configuration parameter set in ROM is sufficient. It saves 16 byte of RAM.
Includes PR #19860 for the moment to be compilable.
Testing procedure
Use
with and w/o this PR and compare the sizes.
Without the PR the sizes are:
With the PR the sizes are:
Issues/PRs references
Depends on PR #19860