Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/at86rf215: switch example config to use EXT3 on same54-xpro #19912

Merged
merged 2 commits into from Sep 5, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Sep 4, 2023

Contribution description

Attaching the at86rf215 reference module to a same54-xpro (via EXT1) stops working after 2a255ff configured the PHY IRQ pin to produce interrupts.

This is because both the PHY IRQ (PD12) as well as the at86rf215 IRQ (PB07) map to EXI7.
Whatever of the two pins gets configured last wins.

Testing procedure

Attach the REB215-XPRO module to EXT3 on same54-xpro.
Frame reception should now work again even if sam0_eth is in use.

Issues/PRs references

fixes #19911

@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: drivers Area: Device drivers Area: cpu Area: CPU/MCU ports labels Sep 4, 2023
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 4, 2023
@riot-ci
Copy link

riot-ci commented Sep 4, 2023

Murdock results

✔️ PASSED

05bf944 drivers/at86rf215: switch example config to use EXT3 on same54-xpro

Success Failures Total Runtime
7967 0 7968 14m:24s

Artifacts

Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense.
I also compared the new pins assignment against SAME54-XPRO user manual.
Looks like this is all good.

@dylad
Copy link
Member

dylad commented Sep 5, 2023

bors merge

bors bot added a commit that referenced this pull request Sep 5, 2023
19912: drivers/at86rf215: switch example config to use EXT3 on same54-xpro  r=dylad a=benpicco



Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
@bors
Copy link
Contributor

bors bot commented Sep 5, 2023

Build failed:

@aabadie
Copy link
Contributor

aabadie commented Sep 5, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 5, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit da7deb5 into RIOT-OS:master Sep 5, 2023
26 checks passed
@benpicco benpicco deleted the boards/same54-xpro_at86rf215 branch September 5, 2023 15:43
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

at86rf215 stops receiving when sam0_eth is in use
5 participants