cpu/stm32: FMC used for low-level LCD parallel interface #19943

gschorcht · 2023-09-23T06:19:17Z

Contribution description

This PR provides the implementation of the LCD low-level MCU 8080 parallel interface using the FMC peripheral.

Testing procedure

BOARD=stm32f723e-disco make -C tests/drivers/st77xx flash

and

BOARD=stm32l496g-disco make -C tests/drivers/st77xx flash

should work on top of PR #19941. Drawing operations should be much faster.

Issues/PRs references

Depends on PR #19941

19941: drivers/lcd: add MCU-driven low-level parallel interface r=benpicco a=gschorcht ### Contribution description The PR extends the LCD driver by a low-level interface for MCU-driven implementations of the MCU 8080 16-/8-bit parallel interface, allowing the MCU to use special peripherals for the interface, such as the FMC for STM32 MCUs, which is significantly faster than the integrated GPIO-driven parallel interface implementation of the LCD driver. ### Testing procedure ~Once PR #19938 and PR #19939 are merged, a PRs for these board can be pushed that allow to test this PR.~ Use either PR #19943 or PR #19944 on top of this PR to test, e.g. with PR #19943: ``` BOARD=stm32f723e-disco make -j8 -C tests/drivers/st77xx flash ``` ### Issues/PRs references Co-authored-by: Gunar Schorcht <gunar@schorcht.net>

riot-ci · 2023-10-05T17:47:53Z

Murdock results

✔️ PASSED

c548efd tests/drivers/st77xx: blacklist nucleo-l031k6

Success	Failures	Total	Runtime
134568	0	134568	04h:20m:39s

Artifacts

Documentation preview

boards/stm32f723e-disco/include/periph_conf.h

boards/stm32l496g-disco/include/periph_conf.h

aabadie

Found a couple of typos but otherwise that looks good. And most important I tested this PR with success on the stm32f723e-disco.

You can squash the minor comments directly and merge when ready.

ACK

gschorcht · 2023-10-06T11:59:58Z

You can squash the minor comments directly and merge when ready.

ACK

Thanks for reviewing and testing. I squashed it. I don't know whether we can merge the PR due the soft freeze. On the other hand its impact is quite low.

aabadie · 2023-10-06T12:05:28Z

I don't know whether we can merge the PR due the soft freeze. On the other hand its impact is quite low.

IMHO this is fine. It's a new feature that extends (and improves) something that was added during this release cycle.

aabadie · 2023-10-06T12:50:22Z

bors merge

19943: cpu/stm32: FMC used for low-level LCD parallel interface r=aabadie a=gschorcht ### Contribution description This PR provides the implementation of the LCD low-level MCU 8080 parallel interface using the FMC peripheral. ### Testing procedure ``` BOARD=stm32f723e-disco make -C tests/drivers/st77xx flash ``` and ``` BOARD=stm32l496g-disco make -C tests/drivers/st77xx flash ``` should work on top of PR #19941. Drawing operations should be much faster. ### Issues/PRs references Depends on PR #19941 Co-authored-by: Gunar Schorcht <gunar@schorcht.net>

aabadie · 2023-10-13T10:01:11Z

bors merge

19943: cpu/stm32: FMC used for low-level LCD parallel interface r=aabadie a=gschorcht ### Contribution description This PR provides the implementation of the LCD low-level MCU 8080 parallel interface using the FMC peripheral. ### Testing procedure ``` BOARD=stm32f723e-disco make -C tests/drivers/st77xx flash ``` and ``` BOARD=stm32l496g-disco make -C tests/drivers/st77xx flash ``` should work on top of PR #19941. Drawing operations should be much faster. ### Issues/PRs references Depends on PR #19941 Co-authored-by: Gunar Schorcht <gunar@schorcht.net>

bors · 2023-10-13T10:21:23Z

Build failed:

static-tests

gschorcht · 2023-10-13T14:30:58Z

Hm, adding the MCU low-level interface seems to increase the ROM 🤔

gschorcht · 2023-10-13T14:35:27Z

Hm, adding the MCU low-level interface seems to increase the ROM 🤔

I don't really get it, if lcd_parallel_ll_mcu is not used, there should be no additional code. It's probably caused by the additional benchmark test in this PR.

gschorcht · 2023-10-13T14:40:06Z

Ok, I blacklisted the nucleo-l031k6 but I don't know what other boards might need to be added to the blacklist.

gschorcht · 2023-10-15T14:36:41Z

@MrKevinWeiss @aabadie Full compilation was successful after blacklisting this one board. Do we want to merge it as part of hard feature freeze?

aabadie · 2023-10-15T14:47:31Z

Do we wan't to merge it as part of hard feature freeze?

I'm fine with that but better wait for the release manager opinion.

MrKevinWeiss · 2023-10-16T09:46:10Z

We will put it in after the hard feature freeze... so now.

MrKevinWeiss · 2023-10-16T09:46:27Z

bors merge

19943: cpu/stm32: FMC used for low-level LCD parallel interface r=MrKevinWeiss a=gschorcht ### Contribution description This PR provides the implementation of the LCD low-level MCU 8080 parallel interface using the FMC peripheral. ### Testing procedure ``` BOARD=stm32f723e-disco make -C tests/drivers/st77xx flash ``` and ``` BOARD=stm32l496g-disco make -C tests/drivers/st77xx flash ``` should work on top of PR #19941. Drawing operations should be much faster. ### Issues/PRs references Depends on PR #19941 Co-authored-by: Gunar Schorcht <gunar@schorcht.net>

bors · 2023-10-16T10:11:44Z

Build failed:

static-tests

maribu · 2023-10-16T10:53:41Z

bors cancel

I stopped the Murdock run, since this failed already due to static tests not passing (codespell on bors got updated). But when added to a merge train together with #19978, it might pass :)

maribu · 2023-10-16T11:11:52Z

bors merge

bors · 2023-10-16T15:31:16Z

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

gschorcht · 2023-10-16T17:29:09Z

Thanks for reviewing and merging 😄

gschorcht requested review from leandrolanzieri, jia200x, MrKevinWeiss, smlng, aabadie, MichelRottleuthner, fjmolinas, DipSwitch and vincent-d as code owners September 23, 2023 06:19

github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: tests Area: tests and testing framework Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration labels Sep 23, 2023

gschorcht added State: waiting for other PR State: The PR requires another PR to be merged first Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Sep 23, 2023

gschorcht mentioned this pull request Sep 27, 2023

drivers/lcd: add MCU-driven low-level parallel interface #19941

Merged

gschorcht force-pushed the cpu/stm32/lcd_parallel_ll_mcu branch from 63d6a35 to 23bea86 Compare October 5, 2023 16:35

gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Oct 5, 2023

aabadie reviewed Oct 6, 2023

View reviewed changes

boards/stm32f723e-disco/include/periph_conf.h Outdated Show resolved Hide resolved

aabadie reviewed Oct 6, 2023

View reviewed changes

boards/stm32l496g-disco/include/periph_conf.h Outdated Show resolved Hide resolved

aabadie approved these changes Oct 6, 2023

View reviewed changes

gschorcht force-pushed the cpu/stm32/lcd_parallel_ll_mcu branch from 23bea86 to 17a4a79 Compare October 6, 2023 11:57

aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 13, 2023

tests/drivers/st77xx: blacklist nucleo-l031k6

c548efd

bors bot merged commit 554efb7 into RIOT-OS:master Oct 16, 2023
29 checks passed

gschorcht deleted the cpu/stm32/lcd_parallel_ll_mcu branch December 6, 2023 07:00

MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cpu/stm32: FMC used for low-level LCD parallel interface #19943

cpu/stm32: FMC used for low-level LCD parallel interface #19943

gschorcht commented Sep 23, 2023

riot-ci commented Oct 5, 2023 •

edited

aabadie left a comment

gschorcht commented Oct 6, 2023

aabadie commented Oct 6, 2023

aabadie commented Oct 6, 2023

aabadie commented Oct 13, 2023

bors bot commented Oct 13, 2023

gschorcht commented Oct 13, 2023

gschorcht commented Oct 13, 2023 •

edited

gschorcht commented Oct 13, 2023

gschorcht commented Oct 15, 2023 •

edited

aabadie commented Oct 15, 2023

MrKevinWeiss commented Oct 16, 2023

MrKevinWeiss commented Oct 16, 2023

bors bot commented Oct 16, 2023

maribu commented Oct 16, 2023

maribu commented Oct 16, 2023

bors bot commented Oct 16, 2023

gschorcht commented Oct 16, 2023

cpu/stm32: FMC used for low-level LCD parallel interface #19943

cpu/stm32: FMC used for low-level LCD parallel interface #19943

Conversation

gschorcht commented Sep 23, 2023

Contribution description

Testing procedure

Issues/PRs references

riot-ci commented Oct 5, 2023 • edited

Murdock results

Artifacts

aabadie left a comment

Choose a reason for hiding this comment

gschorcht commented Oct 6, 2023

aabadie commented Oct 6, 2023

aabadie commented Oct 6, 2023

aabadie commented Oct 13, 2023

bors bot commented Oct 13, 2023

gschorcht commented Oct 13, 2023

gschorcht commented Oct 13, 2023 • edited

gschorcht commented Oct 13, 2023

gschorcht commented Oct 15, 2023 • edited

aabadie commented Oct 15, 2023

MrKevinWeiss commented Oct 16, 2023

MrKevinWeiss commented Oct 16, 2023

bors bot commented Oct 16, 2023

maribu commented Oct 16, 2023

maribu commented Oct 16, 2023

bors bot commented Oct 16, 2023

gschorcht commented Oct 16, 2023

riot-ci commented Oct 5, 2023 •

edited

gschorcht commented Oct 13, 2023 •

edited

gschorcht commented Oct 15, 2023 •

edited