sys/psa_crypto: allow repeated initialization #19990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mguetschow
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
github-actions
bot
added
Area: tests
benpicco
added
the
CI: ready for build
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 20, 2023
19990: sys/psa_crypto: allow repeated initialization r=miri64 a=mguetschow ### Contribution description - simple unit test which calls `psa_crypto_init()` twice - fix to no re-initialize key slots (which left them in a broken state) ### Testing procedure - `make -C tests/sys/psa_crypto all test` succeeds - `git checkout HEAD~1 && make -C tests/sys/psa_crypto all test` fails Co-authored-by: Mikolai Gütschow <mikolai.guetschow@tu-dresden.de>
|
Build failed: |
|
The test is to large for BOARD_INSUFFICIENT_MEMORY := \
arduino-nano \
# |
|
It might be worth to run cd tests/sys/psa_crypto
./../../../dist/tools/insufficient_memory/create_makefile.ci.shdirectly (takes a while but uses Docker). Not sure, if Murdock cancels early if a build fails. |
Done. Should be ready for the next try. |
|
bors merge |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors bot
added a commit
that referenced
this pull request
Oct 23, 2023
19990: sys/psa_crypto: allow repeated initialization r=benpicco a=mguetschow ### Contribution description - simple unit test which calls `psa_crypto_init()` twice - fix to no re-initialize key slots (which left them in a broken state) ### Testing procedure - `make -C tests/sys/psa_crypto all test` succeeds - `git checkout HEAD~1 && make -C tests/sys/psa_crypto all test` fails 20011: tests/unittests: add a unit test for ztimer r=benpicco a=maribu ### Contribution description This adds test coverage for removing ztimers with focus on ensuring that offsets are correctly updated on subsequent timers (e.g. not having timers fire too early). ### Testing procedure Run the unit tests (will be done by the CI as well). Maybe also introduce a random bug in `ztimer_remove()` and check if this is indeed caught by the unit tests. ### Issues/PRs references Prompted by #18977 (comment) Co-authored-by: Mikolai Gütschow <mikolai.guetschow@tu-dresden.de> Co-authored-by: Marian Buschsieweke <marian.buschsieweke@posteo.net>
|
Build failed (retrying...): |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
psa_crypto_init()twiceTesting procedure
make -C tests/sys/psa_crypto all testsucceedsgit checkout HEAD~1 && make -C tests/sys/psa_crypto all testfails