Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-test.yml: Add strasbourg creds [backport 2023.10] #20013

Merged
merged 2 commits into from Oct 24, 2023
Merged

release-test.yml: Add strasbourg creds [backport 2023.10] #20013

merged 2 commits into from Oct 24, 2023

Conversation

MrKevinWeiss
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss commented Oct 24, 2023 •
edited

Backport of #20007 and #20008

Contribution description

This adds creds for stasbourg needed for the openmote-b tests in the release specs.

Testing procedure

Hmmm... I don't know how easy it is. I will try to link results of the workflow from my personal fork maybe?

Issues/PRs references

Needed for RIOT-OS/Release-Specs#289

@MrKevinWeiss
release-test.yml: Add stasbourg creds
924574a 
(cherry picked from commit ad0edec)
@MrKevinWeiss MrKevinWeiss added Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Oct 24, 2023
@riot-ci
Copy link

riot-ci commented Oct 24, 2023 •
edited

Murdock results

✔️ PASSED

a1088d2 release-test.yml: Fix strasbourg spelling

Success Failures Total Runtime
1 0 1 01m:01s

Artifacts

@MrKevinWeiss
Copy link
Contributor Author

This is needed before the spelling fix...

@miri64
Copy link
Member

miri64 commented Oct 24, 2023

Can't you just add the spelling fix to this? Speeds up the process a bit.

@miri64
Copy link
Member

miri64 commented Oct 24, 2023 •
edited 

git cherry-pick -x 51ee3b64dcde618eaa415a55aa331ec6024a6be7

;-)

@MrKevinWeiss
release-test.yml: Fix strasbourg spelling
a1088d2 
Small typo fix... stasbourg -> strasbourg

(cherry picked from commit 51ee3b6)
@MrKevinWeiss
Copy link
Contributor Author

I didn't think it would need a backport but it seems like the release manager script triggers the workflow of the RC and not of master...

@miri64
Copy link
Member

miri64 commented Oct 24, 2023

I didn't think it would need a backport but it seems like the release manager script triggers the workflow of the RC and not of master...

Yes, why would use the master?

@MrKevinWeiss
Copy link
Contributor Author

Yes, why would use the master?

Triggering manually does it and also that would have solved my immediate problem 😎

@aabadie aabadie changed the title release-test.yml: Add stasbourg creds [backport 2023.10] release-test.yml: Add strasbourg creds [backport 2023.10] Oct 24, 2023
@miri64
Copy link
Member

miri64 commented Oct 24, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 24, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit e15ea85 into RIOT-OS:2023.10-branch Oct 24, 2023
26 checks passed
@MrKevinWeiss MrKevinWeiss deleted the backport/2023.10/pr/releaseworkflow branch October 24, 2023 15:42
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2023.10
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrKevinWeiss @riot-ci @miri64 @benpicco